Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Components" sidebar section take a while to load #3850 #4473

Conversation

vrubezhny
Copy link
Contributor

@vrubezhny vrubezhny commented Sep 15, 2024

Fixes: #3850
Depends on: #4467

Signed-off-by: Victor Rubezhny [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 12 lines in your changes missing coverage. Please review.

Project coverage is 43.84%. Comparing base (da60441) to head (9f8055f).
Report is 573 commits behind head on main.

Files with missing lines Patch % Lines
src/odo/odoPreference.ts 89.85% 7 Missing ⚠️
src/registriesView.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4473       +/-   ##
===========================================
+ Coverage   32.37%   43.84%   +11.47%     
===========================================
  Files          85       99       +14     
  Lines        6505     8060     +1555     
  Branches     1349     1691      +342     
===========================================
+ Hits         2106     3534     +1428     
- Misses       4399     4526      +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny marked this pull request as draft September 15, 2024 21:13
@vrubezhny vrubezhny force-pushed the fix-work-with-odo-devfile-registries-preferences branch 26 times, most recently from 27e3a42 to 99c31d4 Compare September 20, 2024 20:05
@vrubezhny vrubezhny force-pushed the fix-work-with-odo-devfile-registries-preferences branch from 99c31d4 to ba1c269 Compare September 23, 2024 13:11
@vrubezhny vrubezhny force-pushed the fix-work-with-odo-devfile-registries-preferences branch 11 times, most recently from 69bbebd to caea0c0 Compare September 24, 2024 02:27
@vrubezhny
Copy link
Contributor Author

This PR depends on #4467

@datho7561
Copy link
Contributor

If I add a new registry (eg. https://registry.stage.devfile.io) it appears in the sidebar. However, when I open the Devfile browser, the new Devfiles aren't shown. If I manually hit the refresh button and reopen the Devfile browser, then it seems to work.

If there is an error in the registry URL (eg. I use http instead of https or I misspell some part of the URL), there is an error in the logs, but no notification pops up to tell me that it failed. The only way I can tell that it failed is that there is nothing new in the sidebar.

@vrubezhny vrubezhny force-pushed the fix-work-with-odo-devfile-registries-preferences branch from 23580a3 to 6116cf9 Compare October 7, 2024 17:00
@vrubezhny vrubezhny marked this pull request as draft October 7, 2024 19:05
@vrubezhny vrubezhny force-pushed the fix-work-with-odo-devfile-registries-preferences branch from 6116cf9 to 9f8055f Compare October 7, 2024 19:41
@vrubezhny vrubezhny marked this pull request as ready for review October 7, 2024 20:08
@vrubezhny
Copy link
Contributor Author

If I add a new registry (eg. https://registry.stage.devfile.io) it appears in the sidebar. However, when I open the Devfile browser, the new Devfiles aren't shown. If I manually hit the refresh button and reopen the Devfile browser, then it seems to work.

This is for #4467 as this PR only removes the usages of odo preference ...-like command usages.
A believe it's fixed now in #4467. There is still an issue with adding a registry when the Devfile Editor is already opened, but, imho, it's not about the changes made in #4467 nor in this PR - to be fixed later.

If there is an error in the registry URL (eg. I use http instead of https or I misspell some part of the URL), there is an error in the logs, but no notification pops up to tell me that it failed. The only way I can tell that it failed is that there is nothing new in the sidebar.

Fixed in #4467

@vrubezhny
Copy link
Contributor Author

This PR makes it free of any use of odo preference view/add registry/remove registry and makes ~/.odo/preference.yaml file to be correctly initialized and ready to be used by odo (while we continue using it).

This removes the risk of hanging up for about 40 seconds while getting the list of configured Devfile registries in cases when a cluster is not accessible.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me. Thanks, Victor!

@datho7561 datho7561 merged commit bef8d74 into redhat-developer:main Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Components" sidebar section take a while to load
3 participants