-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Components" sidebar section take a while to load #3850 #4473
"Components" sidebar section take a while to load #3850 #4473
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4473 +/- ##
===========================================
+ Coverage 32.37% 43.84% +11.47%
===========================================
Files 85 99 +14
Lines 6505 8060 +1555
Branches 1349 1691 +342
===========================================
+ Hits 2106 3534 +1428
- Misses 4399 4526 +127 ☔ View full report in Codecov by Sentry. |
27e3a42
to
99c31d4
Compare
99c31d4
to
ba1c269
Compare
69bbebd
to
caea0c0
Compare
This PR depends on #4467 |
caea0c0
to
23580a3
Compare
If I add a new registry (eg. https://registry.stage.devfile.io) it appears in the sidebar. However, when I open the Devfile browser, the new Devfiles aren't shown. If I manually hit the refresh button and reopen the Devfile browser, then it seems to work. If there is an error in the registry URL (eg. I use http instead of https or I misspell some part of the URL), there is an error in the logs, but no notification pops up to tell me that it failed. The only way I can tell that it failed is that there is nothing new in the sidebar. |
23580a3
to
6116cf9
Compare
Fixes: redhat-developer#3850 Signed-off-by: Victor Rubezhny <[email protected]>
6116cf9
to
9f8055f
Compare
This is for #4467 as this PR only removes the usages of
Fixed in #4467 |
This PR makes it free of any use of This removes the risk of hanging up for about 40 seconds while getting the list of configured Devfile registries in cases when a cluster is not accessible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me. Thanks, Victor!
Fixes: #3850
Depends on: #4467
Signed-off-by: Victor Rubezhny [email protected]