-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devfile Registry editor is to allow devfile version selection and use… #4467
base: main
Are you sure you want to change the base?
Devfile Registry editor is to allow devfile version selection and use… #4467
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4467 +/- ##
===========================================
+ Coverage 32.37% 43.57% +11.20%
===========================================
Files 85 98 +13
Lines 6505 7974 +1469
Branches 1349 1700 +351
===========================================
+ Hits 2106 3475 +1369
- Misses 4399 4499 +100 ☔ View full report in Codecov by Sentry. |
29ea326
to
2e80f02
Compare
ce00ceb
to
5e119c3
Compare
5e119c3
to
e5a6879
Compare
… when creating a component redhat-developer#4189 Fixes: redhat-developer#4189 Issue: redhat-developer#3850 Signed-off-by: Victor Rubezhny <[email protected]>
e5a6879
to
a880bac
Compare
adding new Devfile registries doesn't seem to work. I tried to add http://registry.stage.devfile.io , and nothing happened: no warnings and it didn't appear in the "Devfile Registries" section of the sidebar |
Try refreshing the Devfile Registry View tree - that is a known issue I fixed in #4473. |
Refreshing didn't work for me. That other PR says that it depends on this one in order to work - is that still the case? Is it possible to move the fix to this PR? |
I could try implementing the fix in this PR... the problem is that it'll need to make even more changes in depending #4473 due to conflicts (as it changes the same code) |
Should I focus on reviewing the other PR then? |
Adding/removing devfile registries are not the part of this PR.... With this one you can focus on the following goals:
The #4473 - is exactly about devfile registry tree, adding/changing/removing registries, refreshing the tree and the cache maintenance and getting rid of |
… when creating a component #4189
Fixes: #4189
Issue: #3850