Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Components" sidebar section take a while to load #3850

Closed
datho7561 opened this issue Jan 29, 2024 · 1 comment · Fixed by #4473
Closed

"Components" sidebar section take a while to load #3850

datho7561 opened this issue Jan 29, 2024 · 1 comment · Fixed by #4473
Assignees
@vrubezhny
Labels
performance

Comments

@datho7561
Copy link
Contributor

When starting up, the "Components" sidebar takes a while to load (a couple of seconds).

A further investigation will need to be performed as to why (eg. which function calls take the longest).
@datho7561 datho7561 self-assigned this Feb 5, 2024
@datho7561 datho7561 moved this to 📋 Backlog in IDE Cloudaptors Feb 5, 2024
@datho7561
Copy link
Contributor Author

Here's how to reproduce the slowness:

  1. set up your kubeconfig to point to an invalid cluster. In my case, I point it to my local crc instance, but don't start crc
  2. launch VS Code, then open the OpenShift sidebar. All the views in the sidebar should take over a minute to load.

Here is the different layes

  1. We call getAllComponents() in activate
  2. This calls OdoWrapper.Instance.getRegistries() to get the list of registries
  3. getRegistries() uses odo preference view -o json in order to dump the config as JSON, which contains the list of registries.

In the version of odo that we bundle with the extension (3.15.0), this call takes ~40 seconds if the cluster is inaccessible. i.e. you can replicate this slow response on command line by calling odo preference view -o json using odo 3.15.0 . Therefore, the root cause is an upstream issue.

However, we can mitigate the implications of this issue by not calling getAllComponents in activate. I don't know why we were doing this anyways, fetching and updating the list of devfile registries should be encapsulated in the registry tree view.

datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 5, 2024
@datho7561
Do not call getAllComponents() in activate
cd85dd7 
Part of redhat-developer#3850

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 mentioned this issue Feb 5, 2024
Merged
@datho7561 datho7561 moved this from 📋 Backlog to 🏗 In progress in IDE Cloudaptors Feb 6, 2024
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 6, 2024
@datho7561
Do not call getAllComponents() in activate
9ae98bd 
Part of redhat-developer#3850

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 6, 2024
@datho7561
Do not call getAllComponents() in activate
7b19597 
Part of redhat-developer#3850

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 6, 2024
@datho7561
Do not call getAllComponents() in activate
09c4ab5 
Part of redhat-developer#3850

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit that referenced this issue Feb 7, 2024
@datho7561
Do not call getAllComponents() in activate
92f60b5 
Part of #3850

Signed-off-by: David Thompson <[email protected]>
@mohitsuman mohitsuman mentioned this issue Jun 27, 2024
Open
@msivasubramaniaan msivasubramaniaan moved this from 🏗 In progress to 📋 Backlog in IDE Cloudaptors Jul 17, 2024
@vrubezhny vrubezhny mentioned this issue Aug 8, 2024
Open
10 tasks
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 13, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
25d9d22 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
@vrubezhny vrubezhny mentioned this issue Sep 13, 2024
Merged
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 13, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
94bc879 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
1c7a105 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
de66bcc 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
0c95ed1 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
e63bd09 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
7583093 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
29ea326 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 15, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
7296a84 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 15, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
fdd132f 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 20, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
99c31d4 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
5e119c3 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
ba1c269 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
7f36a21 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
5812be9 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
125f46f 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
2bd26f7 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
550f1ed 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
43893dc 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
29325de 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
70ffc50 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
e5a6879 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
8817d25 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
b92fd44 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
95aaa62 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
69bbebd 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
caea0c0 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
a880bac 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
23580a3 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
@vrubezhny vrubezhny moved this from 📋 Backlog to 👀 In review in IDE Cloudaptors Sep 25, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 4, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
53207f5 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 7, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
0ed199c 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 7, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
ab6662e 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 7, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
6116cf9 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 7, 2024
@vrubezhny
Devfile Registry editor is to allow devfile version selection and use…
670fabd 
… when creating a component redhat-developer#4189

Fixes: redhat-developer#4189
Issue: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
datho7561 pushed a commit that referenced this issue Oct 7, 2024
@vrubezhny @datho7561
Devfile Registry editor is to allow devfile version selection and use…
763c43e 
… when creating a component #4189

Fixes: #4189
Issue: #3850

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 7, 2024
@vrubezhny
"Components" sidebar section take a while to load redhat-developer#3850
9f8055f 
Fixes: redhat-developer#3850

Signed-off-by: Victor Rubezhny <[email protected]>
datho7561 pushed a commit that referenced this issue Oct 7, 2024
@vrubezhny @datho7561
"Components" sidebar section take a while to load #3850
bef8d74 
Fixes: #3850

Signed-off-by: Victor Rubezhny <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrubezhny vrubezhny

Labels
performance
Projects
IDE Cloudaptors
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

"Components" sidebar section take a while to load #3850 vrubezhny/vscode-openshift-tools
3 participants
@vrubezhny @datho7561 @msivasubramaniaan