Upgrade dependencies #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades two key dependencies to their latest stable versions for improved security, performance, and compatibility: Jackson from 2.18.0 to 2.18.2 and Azure Identity from 1.15.4 to 1.16.3.
- Upgraded Jackson Core library from 2.18.0 to 2.18.2 for bug fixes and improvements
- Updated Azure Identity dependency from 1.15.4 to 1.16.3
- Removed deprecated MSAL4J dependency in favor of Azure Identity
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/pom.xml | Updates Jackson version property and contains a manifest entry modification |
| entraid/pom.xml | Upgrades azure-identity dependency and removes msal4j dependency |
| entraid/src/main/java/redis/clients/authentication/entraid/EntraIDTokenAuthConfigBuilder.java | Removes Exception from close() method signature |
| @@ -222,7 +222,7 @@ | |||
| <archive> | |||
| <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile> | |||
| <manifestEntries> | |||
| <Automatic-Module-Name>${core.module.name}</Automatic-Module-Name> | |||
| <Auatomatic-Module-Name>${core.module.name}</Auatomatic-Module-Name> | |||
There was a problem hiding this comment.
The manifest entry contains a typo: 'Auatomatic-Module-Name' should be 'Automatic-Module-Name'.
Suggested change
| <Auatomatic-Module-Name>${core.module.name}</Auatomatic-Module-Name> | |
| <Automatic-Module-Name>${core.module.name}</Automatic-Module-Name> |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
jacksonandazure-identitydependencies to their latest stable versions to improve security, performance, and compatibility: