Skip to content

Upgrade dependencies #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Upgrade dependencies #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80ac694
deps: Upgrade azure-identity and remove superfluous msal4j dependencies
jruaux Aug 6, 2025
d2309e8
fix: Remove unnecessary `throws` in `AutoCloseable.close()` implement…
jruaux Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<core.module.name>redis.clients.authentication.core</core.module.name>
<slf4j.version>1.7.36</slf4j.version>
<resilience4j.version>1.7.1</resilience4j.version>
<jackson.version>2.18.0</jackson.version>
<jackson.version>2.18.2</jackson.version>
<maven.surefire.version>3.5.2</maven.surefire.version>
</properties>

Expand Down Expand Up @@ -222,7 +222,7 @@
<archive>
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
<manifestEntries>
<Automatic-Module-Name>${core.module.name}</Automatic-Module-Name>
<Auatomatic-Module-Name>${core.module.name}</Auatomatic-Module-Name>
Copy link
Preview

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest entry contains a typo: 'Auatomatic-Module-Name' should be 'Automatic-Module-Name'.

Suggested change
<Auatomatic-Module-Name>${core.module.name}</Auatomatic-Module-Name>
<Automatic-Module-Name>${core.module.name}</Automatic-Module-Name>

Copilot uses AI. Check for mistakes.

</manifestEntries>
</archive>
</configuration>
Expand Down
7 changes: 1 addition & 6 deletions entraid/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,10 @@
<artifactId>redis-authx-core</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>msal4j</artifactId>
<version>1.19.1</version>
</dependency>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-identity</artifactId>
<version>1.15.4</version>
<version>1.16.3</version>
</dependency>
<dependency>
<groupId>junit</groupId>
Expand Down
18 changes: 9 additions & 9 deletions ...aid/src/main/java/redis/clients/authentication/entraid/EntraIDTokenAuthConfigBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Builder class for configuring EntraID token authentication.
* This class provides methods to set various configuration options for EntraID token authentication.
* It extends the TokenAuthConfig.Builder class and implements AutoCloseable.
*
*
* <p>Default values:</p>
* <ul>
* <li>DEFAULT_EXPIRATION_REFRESH_RATIO: 0.75F</li>
Expand All @@ -31,22 +31,22 @@
* <li>DEFAULT_MAX_ATTEMPTS_TO_RETRY: 5</li>
* <li>DEFAULT_DELAY_IN_MS_TO_RETRY: 100 (0.1 second)</li>
* </ul>
*
*
* <p>Configuration options:</p>
* <ul>
* <li>{@link #clientId(String)}: Sets the client ID.</li>
* <li>{@link #secret(String)}: Sets the client secret and configures access with secret.</li>
* <li>{@link #key(PrivateKey, X509Certificate)}: Sets the private key and certificate,
* <li>{@link #key(PrivateKey, X509Certificate)}: Sets the private key and certificate,
* and configures access with certificate.</li>
* <li>{@link #authority(String)}: Sets the authority URL.</li>
* <li>{@link #systemAssignedManagedIdentity()}: Configures system-assigned managed identity.</li>
* <li>{@link #userAssignedManagedIdentity(UserManagedIdentityType, String)}:
* <li>{@link #userAssignedManagedIdentity(UserManagedIdentityType, String)}:
* Configures user-assigned managed identity.</li>
* <li>{@link #customEntraIdAuthenticationSupplier(Supplier)}: Sets a custom authentication supplier.</li>
* <li>{@link #scopes(Set)}: Sets the scopes for the token request.</li>
* <li>{@link #tokenRequestExecTimeoutInMs(int)}: Sets the token request execution timeout in milliseconds.</li>
* </ul>
*
*
* <p>Usage:</p>
* <pre>
* {@code
Expand All @@ -58,7 +58,7 @@
* .build();
* }
* </pre>
*
*
* <p>Note:</p>
* <ul>
* <li>Only one of ServicePrincipal, ManagedIdentity or customEntraIdAuthenticationSupplier can be configured.</li>
Expand All @@ -67,10 +67,10 @@
* For more information and details on how to use, please see:
* <p>https://github.com/redis/jedis/blob/master/docs/advanced-usage.md#token-based-authentication
* <p>https://github.com/redis/lettuce/blob/main/docs/user-guide/connecting-redis.md#microsoft-entra-id-authentication
*
*
* @see TokenAuthConfig.Builder
* @see AutoCloseable
*
*
*/
public class EntraIDTokenAuthConfigBuilder extends TokenAuthConfig.Builder<EntraIDTokenAuthConfigBuilder>
implements AutoCloseable {
Expand Down Expand Up @@ -187,7 +187,7 @@ public TokenAuthConfig build() {
}

@Override
public void close() throws Exception {
public void close() {
clientId = null;
secret = null;
key = null;
Expand Down
Loading