Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable libcpp hardening #24227

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Enable libcpp hardening #24227

wants to merge 6 commits into from

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Nov 21, 2024

Enable _LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG to find some bugs

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@BenPope
build: Increase some test timeouts
cd6167f 
Signed-off-by: Ben Pope <[email protected]>
@BenPope
cluster: Don't dereference nullopt
ecd9eef 
This might be a test-only thing.

Signed-off-by: Ben Pope <[email protected]>
@BenPope
raft: Don't dereference nullopt
4353547 
This might be a test-only thing.

Signed-off-by: Ben Pope <[email protected]>
@BenPope
storage: Don't dereference nullopt
5265555 
This might be a test-only thing.

Signed-off-by: Ben Pope <[email protected]>
@BenPope
build/bazel: Enable _LIBCPP_HARDENING_MODE_DEBUG
0c035ae 
Signed-off-by: Ben Pope <[email protected]>
@BenPope
build/cmake: Enable _LIBCPP_HARDENING_MODE_DEBUG
243c015 
Signed-off-by: Ben Pope <[email protected]>
@BenPope BenPope self-assigned this Nov 21, 2024
@BenPope BenPope changed the title Enable libcpp hrdening Enable libcpp hardening Nov 21, 2024
@rockwotj
Copy link
Contributor

This looks awesome! Nice.

Do we only want to enable this in debug mode?

@BenPope
Copy link
Member Author

BenPope commented Nov 21, 2024 •
edited
Loading

Do we only want to enable this in debug mode?

There are lots of options here, this is the first stage of the experiment.

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Nov 21, 2024 •
edited
Loading

the below tests from https://buildkite.com/redpanda/redpanda/builds/58445#01934e32-7d68-43be-bfa0-b58357ea3df7 have failed and will be retried

test_configuration_rpunit
gtest_raft_rpunit
partition_balancer_simulator_test_rpunit
rm_stm_tests_rpunit

the below tests from https://buildkite.com/redpanda/redpanda/builds/58445#01934e32-7d6a-44cd-a22c-452322575286 have failed and will be retried

test_configuration_rpunit
gtest_raft_rpunit
partition_balancer_simulator_test_rpunit
rm_stm_tests_rpunit

@BenPope BenPope marked this pull request as draft November 21, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BenPope BenPope

Labels
area/build area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenPope @rockwotj @vbotbuildovich