Enable libcpp hardening

bazel/internal.bzl

@@ -32,5 +32,6 @@ def redpanda_copts():
     # this workaround macro was removed. so we'll need to rewrite the format
     # handling for >1000 types.
     copts.append("-DFMT_DEPRECATED_OSTREAM")
+    copts.append("-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG")
 
     return copts

src/v/CMakeLists.txt

@@ -3,6 +3,7 @@ include_directories(${CMAKE_CURRENT_BINARY_DIR})
 
 add_compile_options(-Wall)
 add_compile_definitions(FMT_DEPRECATED_OSTREAM)
+add_compile_definitions(_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG)
 
 #
 # When enabled clang-tidy will be invoked along side the compiler, and

src/v/cluster/topic_table_probe.cc

@@ -21,7 +21,7 @@ namespace cluster {
 
 topic_table_probe::topic_table_probe(const topic_table& topic_table)
   : _topic_table(topic_table)
-  , _node_id(*config::node().node_id()) {
+  , _node_id(config::node().node_id().value_or(model::node_id(0))) {
     setup_metrics();
 }
 

src/v/compression/tests/BUILD

@@ -39,7 +39,7 @@ redpanda_cc_btest(
 
 redpanda_cc_bench(
     name = "zstd_stream_bench",
-    timeout = "short",
+    timeout = "moderate",
     srcs = [
         "zstd_stream_bench.cc",
     ],

src/v/container/tests/BUILD

@@ -93,7 +93,7 @@ redpanda_cc_btest(
 
 redpanda_cc_bench(
     name = "vector_bench",
-    timeout = "short",
+    timeout = "long",
     srcs = [
         "vector_bench.cc",
     ],
@@ -108,7 +108,7 @@ redpanda_cc_bench(
 
 redpanda_cc_bench(
     name = "map_bench",
-    timeout = "short",
+    timeout = "long",
     srcs = [
         "map_bench.cc",
     ],

src/v/raft/group_configuration.cc

@@ -926,6 +926,9 @@ void configuration_change_strategy_v4::replace_brokers(
 
 void configuration_change_strategy_v4::finish_configuration_transition() {
     // if there are no nodes to remove there is no need to enter joint consensus
+    if (!_cfg._configuration_update.has_value()) {
+        return;
+    }
     if (_cfg._configuration_update->replicas_to_remove.empty()) {
         _cfg._configuration_update.reset();
         return;
@@ -1158,6 +1161,9 @@ void configuration_change_strategy_v5::replace(
 
 void configuration_change_strategy_v5::finish_configuration_transition() {
     // if there are no nodes to remove there is no need to enter joint consensus
+    if (!_cfg._configuration_update.has_value()) {
+        return;
+    }
     if (_cfg._configuration_update->replicas_to_remove.empty()) {
         _cfg._configuration_update.reset();
         return;

src/v/storage/disk_log_impl.cc

@@ -2411,10 +2411,9 @@ disk_log_impl::make_reader(timequery_config config) {
                     stlog.debug,
                     "Batch timestamps have monotonically increasing "
                     "timestamps; used segment index to find first batch before "
-                    "timestamp {}: offset={} with ts={}",
+                    "timestamp {}: {}",
                     cfg.time,
-                    index_entry->offset,
-                    index_entry->timestamp);
+                    index_entry);
               }
 
               auto offset_within_segment

src/v/utils/tests/BUILD

@@ -260,7 +260,7 @@ redpanda_cc_btest(
 
 redpanda_cc_bench(
     name = "coro_bench",
-    timeout = "short",
+    timeout = "moderate",
     srcs = [
         "coro_bench.cc",
     ],
@@ -484,7 +484,7 @@ redpanda_cc_btest(
 
 redpanda_cc_bench(
     name = "delta_for_bench",
-    timeout = "short",
+    timeout = "moderate",
     srcs = [
         "delta_for_bench.cc",
     ],