Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pandaproxy/sr: protobuf rendering: refactor string rendering #24992

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

pandaproxy/sr: protobuf rendering: refactor string rendering #24992

wants to merge 1 commit into from
+32 −11

Conversation

IoannisRP
Copy link
Contributor

@IoannisRP IoannisRP commented Jan 31, 2025 •
edited by jira bot
Loading

Implements: CORE-8906

Refactored string rendering to use absl::CEscape instead of fmt debug format.

It is done for 2 reasons:

  1. Debug format is not supported in earlier versions of fmt that we still use.
  2. Make the intent more explicit.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@IoannisRP
pandaproxy/sr: protobuf rendering: refactor string rendering
efdbf23 
Moved away from fmt debug format for 2 reasons:
1. Debug format is not supported in earlier versions of fmt
that we still use.
2. Make the intent more explicit.
@IoannisRP IoannisRP requested a review from BenPope January 31, 2025 18:52
This was referenced Jan 31, 2025
Open
Open
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#61451
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/61451#0194bdb7-145c-4cf9-bbf3-947af84289a1 FLAKY 1/2
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/61451#0194bdb7-145d-44a0-8364-de6a2945b3eb FLAKY 1/2
rptest.tests.compaction_recovery_test.CompactionRecoveryTest.test_index_recovery ducktape https://buildkite.com/redpanda/redpanda/builds/61451#0194bdfb-83b1-46db-a935-d438943c01fe FLAKY 1/2
rptest.tests.compaction_recovery_test.CompactionRecoveryTest.test_index_recovery ducktape https://buildkite.com/redpanda/redpanda/builds/61451#0194be00-6ef6-4d29-addd-c492087cbeb5 FLAKY 1/2
rptest.tests.controller_log_limiting_test.ControllerLogLimitMirrorMakerTests.test_mirror_maker_with_limits ducktape https://buildkite.com/redpanda/redpanda/builds/61451#0194be00-6ef4-415d-8c83-570c90f2f23b FLAKY 1/2
rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=0.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/61451#0194be00-6ef4-415d-8c83-570c90f2f23b FLAKY 1/2
rptest.tests.scaling_up_test.ScalingUpTest.test_scaling_up_with_recovered_topic ducktape https://buildkite.com/redpanda/redpanda/builds/61451#0194be00-6ef4-415d-8c83-570c90f2f23b FLAKY 1/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPope BenPope BenPope approved these changes

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IoannisRP @vbotbuildovich @BenPope