Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunk Check Workflow #3787

Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Replacing assert with assertion exception for when we check whether
the component is a callable
elviskahoro committed Aug 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 4c1636f665165adbf38710b85400c44aa74e9c88
18 changes: 13 additions & 5 deletions reflex/app.py
Original file line number Diff line number Diff line change
@@ -491,11 +491,19 @@ def add_page(
"""
# If the route is not set, get it from the callable.
if route is None:
assert isinstance(
component, Callable
), "Route must be set if component is not a callable."
# Format the route.
route = format.format_route(component.__name__)
match component:
case Callable():
# Format the route.
route = format.format_route(
route=component.__name__,
)

case _:
error_msg: str = "Route must be set if component is not a callable."
raise TypeError(
error_msg,
)

else:
route = format.format_route(route, format_case=False)