-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix matchResponseMapWithRequests
to handle prompt response.
#505
base: develop
Are you sure you want to change the base?
Fix matchResponseMapWithRequests
to handle prompt response.
#505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good patch, but I am slightly concerned about this being prompt. What if someone does something like this?
b <- requesting a
c <- requesting b
Will that create a cycle? It seems like it would. It would be great to add a test for this
Even if that does in fact create a cycle, we could still have something prompt here as an option
I tried to add test for new |
I think we can refactor this code with |
This minimal example demonstrates a request/response interaction. When a request is made, the corresponding response is generated immediately, as seen in the
eResponse
definition. However, the current implementation ofmatchResponseMapWithRequests
doesn't correctly handle prompt responses, resulting in "Got Response!" not being printed fromeX
. This fix ensures that prompt responses are handled correctly, allowing "Got Response!" to be printed as expected.