feat: APP-266 add sellOrderPrice to project document #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blushi
commented
Sep 9, 2024
| @@ -25,6 +25,16 @@ export default { | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Sounds good. Thanks! I hadn't thought of that edge case.
blushi
commented
Sep 9, 2024
| { | ||
| title: 'Sell order price', | ||
| description: 'price per credit in USD', | ||
| name: 'usdPrice', |
There was a problem hiding this comment.
this gives us more flexibility to put the price at the sell order level but if we think that we'll want to always define the same credit price for a given project, we could put this at the project document level cc/ @clevinson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exploring sanity option for https://regennetwork.atlassian.net/browse/APP-266
Check comment with explanation: https://regennetwork.atlassian.net/browse/APP-266?focusedCommentId=10687
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
./deskStructure.jsReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...