-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-266 add sellOrderPrice to project document #64
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
export default { | ||
title: 'Sell Order Price', | ||
name: 'sellOrderPrice', | ||
type: 'object', | ||
fields: [ | ||
{ | ||
title: 'Sell order id', | ||
name: 'sellOrderId', | ||
type: 'string', | ||
validation: Rule => Rule.required(), | ||
}, | ||
{ | ||
title: 'Sell order price', | ||
description: 'price per credit in USD', | ||
name: 'usdPrice', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this gives us more flexibility to put the price at the sell order level but if we think that we'll want to always define the same credit price for a given project, we could put this at the project document level cc/ @clevinson There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense to me. |
||
type: 'number', | ||
validation: Rule => Rule.required(), | ||
}, | ||
], | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clevinson see my comment in https://regennetwork.atlassian.net/browse/APP-266?focusedCommentId=10687
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Thanks! I hadn't thought of that edge case.