Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-494 tebu factors card grid display #2557

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

blushi
Copy link
Member

@blushi blushi commented Nov 26, 2024

Description

https://regennetwork.atlassian.net/browse/APP-494


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 977132a
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/6746d3a6fb40bd00081ffcfa
😎 Deploy Preview https://deploy-preview-2557--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 977132a
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/6746d3a6a94d52000814bae9
😎 Deploy Preview https://deploy-preview-2557--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member Author

blushi commented Nov 26, 2024

@blushi blushi requested a review from flagrede November 26, 2024 09:48
@erikalogie
Copy link
Collaborator

erikalogie commented Nov 26, 2024

This looks great. The only part that I think looks a bit weird is the sizing of the text for the pie graph at certain sizes (text looks quite big in screenshot below), but we have not really as a practice optimized our app across every screen size so maybe it is ok:
Screenshot 2024-11-26 at 8 44 49 AM

@blushi
Copy link
Member Author

blushi commented Nov 26, 2024

This looks great. The only part that I think looks a bit weird is the sizing of the text for the pie graph at certain sizes (text looks quite big in screenshot below), but we have not really as a practice optimized our app across every screen size so maybe it is ok: Screenshot 2024-11-26 at 8 44 49 AM

The pie is rendered as an svg by the victory lib so I'd have to look into how to tweak this, let's rather open up a separate task

@erikalogie
Copy link
Collaborator

Ok great, yeah not that important, this task looks good though

@blushi blushi force-pushed the fix-APP-494-tebu-cards-ui branch from c4722ec to 977132a Compare November 27, 2024 08:09
@blushi blushi merged commit 4373e31 into dev Nov 27, 2024
18 checks passed
@blushi blushi deleted the fix-APP-494-tebu-cards-ui branch November 27, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants