Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-494 tebu factors card grid display #2557

Merged
merged 1 commit into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ import Box from '@mui/material/Box';

import { Body } from '../../typography';

export interface ThreatBodyProps {
export interface CommonBodyProps {
icon: JSX.Element;
description: JSX.Element | string;
title: string;
}

const ThreatBody: React.FC<ThreatBodyProps> = ({
const CommonBody: React.FC<CommonBodyProps> = ({
title,
description,
icon,
Expand All @@ -21,12 +21,10 @@ const ThreatBody: React.FC<ThreatBodyProps> = ({
<Body className="font-montserrat text-[16px] mt-[12px] font-bold mb-5">
{title}
</Body>
<Body className="font-montserrat text-[12px] pmb-[10px]">
{description}
</Body>
<Body className="font-montserrat text-[12px] pb-20">{description}</Body>
</Box>
</Box>
);
};

export default ThreatBody;
export default CommonBody;
2 changes: 1 addition & 1 deletion web-components/src/components/cards/TebuCard/TebuCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function TebuCard({
return (
<Card
className={cn(
'text-sc-text-header w-full min-w-[250px] h-[239px] font-montserrat border-sc-card-standard-stroke relative',
'text-sc-text-header w-full min-h-[239px] font-montserrat border-sc-card-standard-stroke relative',
className,
)}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const TebuInfo: React.FC<TebuInfoProps> = ({
)}
learnMoreLink={{ href: learnMoreLink, text: _(msg`Learn more`) }}
>
<div className="grid grid-cols-1 sm:grid-cols-2 gap-20 mt-4 justify-items-center sm:justify-items-start">
<div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-1 xl:grid-cols-2 gap-20 mt-4 justify-items-center sm:justify-items-start">
{threatCard}
{connectivityCard}
{durationCard}
Expand Down