Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-366 account orders #2566

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

feat: APP-366 account orders #2566

wants to merge 18 commits into from

Conversation

blushi
Copy link
Member

@blushi blushi commented Dec 2, 2024

Description

https://regennetwork.atlassian.net/browse/APP-366


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

From https://deploy-preview-2566--regen-marketplace.netlify.app/

  1. First, login and buy some credits with fiat and with crypto (older crypto orders below a certain block height are not available on staging because of state pruning on our redwood node, this won't be the case on mainnet since we use the archive node where we should be able to see old crypto orders)
  2. Check out "my orders" and verify orders info there

NB: credit card info is missing for now, I've realized that we need some server update for that, which I'm working on, but the rest can still be tested in the mean time. DONE

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 7285015
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/67596c2c79d9dc00082d2a55
😎 Deploy Preview https://deploy-preview-2566--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 7285015
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/67596c2bd4c8dd00082aa941
😎 Deploy Preview https://deploy-preview-2566--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi requested a review from r41ph December 4, 2024 13:12
@blushi
Copy link
Member Author

blushi commented Dec 4, 2024

@erikalogie @S4mmyb see testing instructions

@erikalogie
Copy link
Collaborator

Some styling and other comments:
Monosnap Regen Marketplace 2024-12-05 10-26-38

Monosnap Regen Marketplace 2024-12-05 10-54-06 Monosnap Regen Marketplace 2024-12-05 10-28-52 Monosnap Regen Marketplace 2024-12-05 10-58-46

On another notes, do we need a task to have the name of the user account change to the name that I put in the 2nd step of the buy flow?

@blushi
Copy link
Member Author

blushi commented Dec 5, 2024

On another notes, do we need a task to have the name of the user account change to the name that I put in the 2nd step of the buy flow?

We have one: https://regennetwork.atlassian.net/browse/APP-441

@blushi
Copy link
Member Author

blushi commented Dec 9, 2024

@erikalogie you can have another look, I've also added support for displayed credit card info.

@erikalogie
Copy link
Collaborator

A few more small alignment things:

Monosnap Regen Marketplace 2024-12-09 10-22-28 Monosnap Screenshot 2024-12-09 at 10 19 05 AM 2024-12-09 10-19-37

@blushi
Copy link
Member Author

blushi commented Dec 9, 2024

Monosnap Regen Marketplace 2024-12-09 10-22-28 Monosnap Screenshot 2024-12-09 at 10 19 05 AM 2024-12-09 10-19-37

@erikalogie how much should I increase the space between image and project name/id on mobile? there's a space of 10px as on figma

@erikalogie
Copy link
Collaborator

Monosnap Regen Marketplace 2024-12-09 10-22-28 Monosnap Screenshot 2024-12-09 at 10 19 05 AM 2024-12-09 10-19-37

@erikalogie how much should I increase the space between image and title on mobile? there's a space of 10px as on figma

on Figma it is 20px between the two sections, you can see here, and same on mobile and desktop:

Monosnap Fiat payments 2024-12-09 10-31-55

@blushi
Copy link
Member Author

blushi commented Dec 9, 2024

@erikalogie I'm asking about this:
image

@erikalogie
Copy link
Collaborator

@erikalogie I'm asking about this: image

Oh maybe that part will look fine if the space below is changed. So leave it for now.

@blushi blushi force-pushed the feat-APP-366-account-orders branch from 6c2886b to 5c14ced Compare December 10, 2024 09:08
@blushi
Copy link
Member Author

blushi commented Dec 10, 2024

@erikalogie you can have another look
Although we need to wait on https://github.com/regen-network/regen-server/pull/517 to be merged before testing the stripe receipt, that I've implemented (not yet pushed)
I'll create a follow-up task to implement the custom receipt popup for crypto purchases

@erikalogie
Copy link
Collaborator

Everything looks good, just let me know when the server PR is merged and I can test the stripe receipt button

@blushi blushi force-pushed the feat-APP-366-account-orders branch from 3b29600 to 4243cae Compare December 11, 2024 09:45
@blushi
Copy link
Member Author

blushi commented Dec 11, 2024

Everything looks good, just let me know when the server PR is merged and I can test the stripe receipt button

@erikalogie you can test this now

@erikalogie
Copy link
Collaborator

LGTM! Nice work here

@blushi
Copy link
Member Author

blushi commented Dec 12, 2024

@r41ph I've added some new stuff since your initial approval, so let me know if you wanna have another look before I merge this, thanks!

@r41ph
Copy link
Contributor

r41ph commented Dec 12, 2024

@blushi the code looks good to me. A couple of things:

Storybook
image

Figma
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants