Looting rewrite #120
Looting rewrite #120
Conversation
No functional changes, but runs faster and is cleaner.
This does not change the looting results, simply optimizes performance. In my tests if all the bodies in the world are inside the looting radius, this new code is a bit slower, but it becomes faster whenever over half of the bodies are outside the looting radius, which is usually the case in Overthrow.
This code now properly loots everything that might be in an item pile or weapon holder. It also fixes bugs where weapon magazines and some attachments were not looted.
This code now properly loots every item that a body has in its inventory. Also fixes some bugs where weapon magazines and nested backpacks were not looted.
Does mostly the same thing as before, but with few bugs fixed: - If looter was in a vehicle, it was not checked if the vehicle was of valid type. - If multiple looters were selected for looting and one of them was in recovery truck, the ones with a lower number would still go looting by foot.
Also optimizes some of them a bit
Changes/fixes: - Looter no longer enters the vehicle as passenger after looting - If bodies disappear while looting, they are skipped - If the looting vehicle is destroyed, the looting is canceled - All items are now properly looted, including for example weapon attached magazines - All item piles on the ground are looted, in addition to just dropped weapons (useful when a player has already been digging in the pockets of the bodies before looting) - Dropped weapons are looted by the looter instead of teleporting to the vehicle - Weapons that are dropped just outside the looting range by bodies inside the range are also looted, instead of getting deleted
This variable has been used to mark bodies for deletion, but looting mechanisms already delete all bodies anyway. Now the only use case left is to delete bodies that have been completely looted manually by hand. It is so rare that players would loot a body completely empty by hand that I think it's better to just delete it.
This new variable is intentionally local. If multiple players start looting the same area, they won't know if the other already has a looter going for a body.
getCorpse command, introduced in 2.12, is used in the new looting code.
|
|
||
| _t = _this select 1; | ||
| _looter doMove ASLtoAGL (getPosASL _target); |
There was a problem hiding this comment.
We might want to experiment with using moveTo rather than doMove. I believe that with moveTo the unit will attempt to return to formation automatically after moving (or failing to move), whereas with doMove the unit must be explicitly ordered to return. Read notes on the biki page for doMove for more info.
There was a problem hiding this comment.
This is not my code so I don't know the original idea, but is the looter supposed to return to formation after moving? Now it stays wherever it was ordered to go in "ready" state. Both results make sense.
|
|
||
| // Wait until looter reaches the body | ||
| _timeout = time + 30; | ||
| waitUntil {sleep 1; (_looter distance2D _body < 12) || (isNull _body) || (!alive _looter) || (!alive _target) || (_timeout < time)}; |
There was a problem hiding this comment.
moveToCompleted could be used here to avoid waiting the full timeout if the unit fails to reach the destination.
There was a problem hiding this comment.
Seems reasonable. The timeout may not be needed if moveToCompleted always returns true when moving fails.
| _looter setUnitLoadout _lootedLoadout; | ||
| [_body] call OT_fnc_cleanupUnit; | ||
|
|
||
| sleep 2; |
There was a problem hiding this comment.
Why wait 2 seconds here, the unit could already start running. In my opinion the looter should be almost constantly moving, small stops are ok but 2 seconds is too long in my opinion.
There was a problem hiding this comment.
This is not my code so I don't know the original idea, but I think it's meant to simulate the looter spending time to pick up the items.
|
Awesome work. It might take me a while to review and merge, this needs a lot of testing and maybe some small tweaks here and there. |
Partial rewrite of the looting code, for both recovery truck and recruit looting. Changes a lot of small details but keeps looting working the same on larger scale.
I created two generic inventory management functions:
OT_fnc_dumpContaineradds all items from one container to another andOT_fnc_dumpUnitLoadoutadds items from unit's loadout to a container. These are based on the latest Arma inventory commands and can correctly copy all items that a container or unit might have, handling all edge cases like half used magazines, weapon attached magazines, items inside backpacks and vests, laser designator batteries, ACE medical item replacements etc. The new looting code uses these functions to handle all inventory management correctly. These will probably replace other inventory management functions in the future, likeOT_fnc_dumpStuffandOT_fnc_transferHelper. Ultimately I think the correct place for these generic functions would be CBA so I might make a pull request there at some point (related: CBATeam/CBA_A3#1551).Outside of inventory management, the looting code now also loots all item piles on the ground. Looting with recruits handles cases like multiple looters looting at the same time. Looters will collect weapons when they visit a body instead of all weapons just teleporting in at the beginning.
See commit messages and code comments for more info.