worker: do not repeatedly remove already awaited tasks from subtask list #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzaoral
force-pushed
the
fix-subtask-waiting
branch
from
58abc2a
to
d044897
Compare
rohanpm
approved these changes
Aug 23, 2023
|
I think you missed a word "not" in the PR summary. |
Plain TaskBase.wait() always uses the **whole** list of all subtasks as
the set of subtasks that should be awaited. Therefore, it will try to
await even tasks that were already awaited in some previous
TaskBase.wait() call and are no longer present in self._subtask_list
which subsequently raise the ValueError shown below.
Keep the set of already awaited tasks and skip their IDs when marking
newly awaited subtasks as finished.
Fixes the following traceback:
```
Traceback (most recent call last):
File "/src/kobo/kobo/worker/taskmanager.py", line 423, in run_task
task.run()
File "/src/osh/worker/tasks/task_errata_diff_build.py", line 55, in run
self.wait()
File "/src/kobo/kobo/worker/task.py", line 147, in wait
self._subtask_list.remove(i)
ValueError: list.remove(x): x not in list
```
lzaoral
force-pushed
the
fix-subtask-waiting
branch
from
d044897
to
fd6006c
Compare
lzaoral
changed the title
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
Aug 23, 2023
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
Aug 24, 2023
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
Sep 4, 2023
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
Sep 12, 2023
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain
TaskBase.wait()always uses the whole list of all subtasks as the set of subtasks that should be awaited. Therefore, it will try to await even tasks that were already awaited in some previousTaskBase.wait()call and are no longer present inself._subtask_listwhich will subsequently raise theValueErrorshown below.Keep the set of already awaited tasks and skip their IDs when marking newly awaited subtasks as finished.
Fixes the following traceback: