Various CI fixes for 2023-11 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be using "apt-get update" to update package lists before installing any new packages. This has never mattered before, but recently the installation of various packages started to fail with 404 errors, which are resolved by updating the package lists first.
Manually ran "pre-commit autoupdate". The new version of isort in particular is necessary to fix install on some newer Python environments.
mypy started to complain with:
pubtools/exodus/gateway.py:8: error: Library stubs not installed for "requests.packages.urllib3.util.retry" [import-untyped]
pubtools/exodus/gateway.py:8: note: Hint: "python3 -m pip install types-requests"
...despite that types-requests *is* already installed. Other projects
have seen similar issues.
As we do not seem to detect any genuine issues with mypy in practice,
let's drop it from the default CI configuration to reduce the CI
maintenance cost. mypy currently remains in the test-requirements.txt
file to enable running the tool locally.
rohanpm
force-pushed
the
ci-apt-get-fix
branch
from
ed3a8a9
to
e01f607
Compare
rohanpm
changed the title
crungehottman
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several CI issues which have arisen on this project lately:
See each of the included commits for more info.