-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use ?inline
to load critical styles
#10254
base: dev
Are you sure you want to change the base?
feat: use ?inline
to load critical styles
#10254
Conversation
Hi @sapphi-red, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
🦋 Changeset detectedLatest commit: dad7725 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you point this at the dev
branch instead, and add a changeset?
297fbd9
to
dad7725
Compare
Sure. I pointed to the |
The default export of css files was removed in Vite v5, but it was accidently left for SSR. Vite v6 removes that (vitejs/vite#17922). This PR changes the critical style loader to use
?inline
imports to make remix compatible with Vite v6.Testing Strategy: I ran
pnpm i && pnpm vite-ecosystem-ci:build && pnpm vite-ecosystem-ci:test
with both Vite 5.x and 6.x.