Lean: preserve more types from sail #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasgrosser
approved these changes
Feb 4, 2025
javra
approved these changes
Feb 4, 2025
lfrenot
approved these changes
Feb 4, 2025
bacam
reviewed
Feb 4, 2025
ineol
force-pushed
the
lean-type-args
branch
2 times, most recently
from
e10be82 to
8ac4e91
Compare
|
Could you rebase this to lose the extra commit? |
ineol
force-pushed
the
lean-type-args
branch
2 times, most recently
from
e99e0ae to
654de7d
Compare
1. Preserve the let type annotations from the sail source 2. Preserve the parameters of types
Done! I also removed an ocurence of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is stacked on top of #951, only look at the second commit!