Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experimental/smart-session #2875

Merged
merged 90 commits into from
Oct 7, 2024
Merged

add experimental/smart-session #2875

merged 90 commits into from
Oct 7, 2024

Conversation

KannuSingh
Copy link
Collaborator

@KannuSingh KannuSingh commented Sep 19, 2024

Description

  • Create new experimental/smart-session package, and implement grantPermissions method as per the spec
  • includes changes on ether, wagmi and universal adapter client to support grantPermissions and getCapabilities
  • Change lab implementation to use the new package @reown/experimental/smart-session instead of custom implementation

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 7, 2024 4:54pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 7, 2024 4:54pm
web3modal-laboratory ❌ Failed (Inspect) Oct 7, 2024 4:54pm

Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: e8766c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 321.53000000000003% 4409 / 19231
🔵 Statements 321.53000000000003% 4409 / 19231
🔵 Functions 343.60999999999996% 346 / 1029
🔵 Branches 380.2% 636 / 1326
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/appkit/src/tests/mocks/UniversalProvider.ts 100% 100% 100% 100%
packages/appkit/src/universal-adapter/client.ts 52.94% 46.55% 48.57% 52.94% 108-112, 130-131, 134, 139-140, 142-144, 153-157, 159-161, 163-165, 167-169, 171-176, 178, 180-189, 191, 193-196, 198-203, 205, 207, 209-212, 225-227, 236-238, 240-242, 244-247, 249-250, 266, 268-270, 272-279, 281-282, 285-288, 290-291, 320-325, 329-334, 344, 346-349, 355-360, 362-363, 366-367, 369-378, 380, 382-383, 400-401, 403-408, 436-437, 439, 444-445, 467-468, 480-483, 485, 487-489, 492-495, 499-500, 502-519, 521-522, 524-527, 565-569, 574-577, 594-595, 607-609, 611-632, 649-650, 652-656
packages/appkit/src/utils/HelpersUtil.ts 100% 90.9% 100% 100%
packages/core/src/controllers/ConnectionController.ts 47.59% 83.33% 24% 47.59% 75-79, 86-87, 93-96, 98-99, 101-102, 104-106, 108-123, 143-145, 148-164, 167-168, 171-172, 175-176, 179-180, 183-184, 187-188, 191-192, 195-196, 199-200, 203-204, 221-222, 225-227, 230-231, 234-235, 238-239, 248-249
packages/experimental/exports/index.ts 100% 100% 100% 100%
packages/experimental/exports/smart-session/index.ts 0% 0% 0% 0% 1
packages/experimental/src/smart-session/grantPermissions.ts 80.72% 52.38% 100% 80.72% 42-43, 50-51, 103-104, 112-113, 117-118, 121-123, 131-132, 140
packages/experimental/src/smart-session/helper/index.ts 85.39% 72.72% 100% 85.39% 21-22, 102, 126-127, 132-133, 136-137, 142-143, 146-147
packages/experimental/src/smart-session/schema/index.ts 100% 100% 85.71% 100%
packages/experimental/src/smart-session/utils/ConstantUtils.ts 100% 100% 100% 100%
packages/experimental/src/smart-session/utils/CosignerService.ts 97.4% 86.66% 100% 97.4% 60-61
packages/experimental/src/smart-session/utils/ERC5792Types.ts 100% 100% 100% 100%
packages/experimental/src/smart-session/utils/TypeUtils.ts 100% 100% 100% 100%
Generated in workflow #6638 for commit e8766c5 by the Vitest Coverage Report Action

Copy link
Collaborator

@lukaisailovic lukaisailovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KannuSingh Please add a short description packages/experimental/readme.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants