Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace with erc6492 lib and call rpc directly w/o http #649

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented May 7, 2024

Description

Removes the dependency on WalletConnectRust and uses the erc6492 library directly. Also upgrades to use a "self provider" pattern where the EVM library directly calls into the RPC proxy function rather than using HTTP.

Two other things:

  • Updates the just Rust version to be stable, rather than nightly, as there were some new clippy errors in nightly that weren't showing in CI
  • Adds Content-Type header to README as this is technically the spec of JSON-RPC, even though Blockchain API doesn't require it. This confused me when I attempted to run the same commands against a regular RPC endpoint but got a bad request because I didn't supply this header.

Remaining work:

  • Iron out error handling in self_transport.rs

How Has This Been Tested?

Not tested?

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant