Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

934 project status filter #964

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Aug 11, 2023

Project status filter

Closes #933
Closes #934
Closes #937

Changes proposed in this pull request:

  • Adding project status filter to project overview page. The filter values are: Pending, In progress, Finished and Unknown. We have chosen a single value filter because the project can have only one of the values. The other filters support multiple values in the AND fashion.
  • Adding projects status filter to organisation project tab. Filter uses same values as on the project overview page.
  • Improved project period presentation on the project card:
    • Project with status unknown do not show any period indication
    • Finished projects show period and progress bar when both values are present. When start date is not present we y show period labels: N/S - Jan 2022
    • In progress projects have always start and end date and show both period labels and progress bar
    • Pending projects show progress bar, if both date values are present, and the period labels. In case one of date values is missing it uses N/S (short for not specified)
  • Aligned project status on the project page (top right corner of the page) and in the related project cards on software and project page

How to test:

  • make start to build and generate test data
  • navigate to project overview page and test Project status filter in combination with other filters
  • clear filters. Selected order should be kept and filters should be removed. The clear button should be disabled.
  • navigate to software overview page. Confirm that clear button works in similar way as on project overview page
  • The project status in the related projects on the software page should have use same values as the filter (Pending, In progress, Finished)
  • navigate to project page. The status at the top right corner should use same status values as the filter (Pending, In progress, Finished)
  • navigate to organisation page:
    • The page should open on software tab, default order should be mentions and the clear button is disabled. After selecting some filters clear button should be enabled. Clear button should clear filters but keep selected order.
    • navigate to project tab. Default order should be impact and the clear button is disabled. After selecting some filters clear button should be enabled. Clear button should clear filters but keep selected order.

Example project overview page

image

Example organisation projects page

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@sonarqubecloud
Copy link

[authentication] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[scrapers] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmaassen
Copy link
Member

Some comments:

  • the behavior of the "status" dropdown menu is different from the others: when selecting an item from "keywords" for example, the selected value is immutable and shown in a rounded box. The others have the same behavior. In the status pulldown menu however, the selected item is simply text, which I can also change. It would be better is this is also immutable.
  • Also, in the others I can select multiple values, but for status I can use only one? Why can't I select "in progess + pending projects"? (which equals "not finished")
  • clearing the filters also changes the sort order. This is a bit unexpected, but could be solved by renaming the button "reset" instead of "clear"?

@dmijatovic dmijatovic force-pushed the 934-project-status-filter branch from 20e6fd9 to 30492fa Compare August 14, 2023 15:48
@dmijatovic
Copy link
Contributor Author

@jmaassen and @ewan-escience I changed the behavour of clear button and project status filter. Can you please confirm that this approach is better. After that I will implement same approach in the organisation projects page. Thanks!

BTW: I also rebased this branch and rsd-v2-release with the latest changes from main

…pages

refactor: change order and clear button behaviour on software, project and organisation pages
chore: upgrade eslint version to avoid warning
@dmijatovic dmijatovic force-pushed the 934-project-status-filter branch from 30492fa to 4f4d6b3 Compare August 15, 2023 12:37
@sonarqubecloud
Copy link

[rsd-database] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.3% 11.3% Duplication

@sonarqubecloud
Copy link

[rsd-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

43.2% 43.2% Coverage
0.6% 0.6% Duplication

Copy link
Member

@jmaassen jmaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't forget to also add it in the org pages?

@dmijatovic dmijatovic merged commit 7ccfc10 into rsd-v2-release Aug 15, 2023
@dmijatovic dmijatovic deleted the 934-project-status-filter branch September 4, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants