Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lighthouse: add arial labels to admin buttons. #977

Merged
merged 1 commit into from
Sep 4, 2023
Merged

lighthouse: add arial labels to admin buttons. #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/components/GlobalSearchAutocomplete/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ export default function GlobalSearchAutocomplete(props: Props) {
</div>
<input className="px-2 pl-8 py-2 bg-transparent rounded-sm border border-base-600 focus:outline-0 w-full focus:bg-base-100 focus:text-base-900 duration-200"
data-testid="global-search"
name="global-search"
placeholder="Search or jump to..."
autoComplete="off"
value={inputValue}
Expand Down
2 changes: 2 additions & 0 deletions frontend/components/menu/IconBtnMenuOnAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export default function IconBtnMenuOnAction({
<MenuItem
data-testid="icon-menu-option"
key={item.label}
aria-label={item.label}
onClick={() => handleAction(item.action)}>
{item.icon ? <span className="mr-2">{item.icon}</span> : null}
{item.label}
Expand All @@ -80,6 +81,7 @@ export default function IconBtnMenuOnAction({
<IconButton
size="large"
data-testid="icon-menu-button"
aria-label='Menu'
aria-controls="more-menu"
aria-haspopup="true"
aria-expanded={open ? 'true' : 'false'}
Expand Down
1 change: 1 addition & 0 deletions frontend/components/organisation/metadata/OrganisationLogoMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ export default function OrganisationLogoMenu({logo, onAddLogo, onRemoveLogo}: Ad
<IconButton
size="large"
data-testid="icon-menu-button"
aria-label="Logo options"
aria-controls="more-menu"
aria-haspopup="true"
aria-expanded={open ? 'true' : 'false'}
Expand Down