Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: jackson 의존성 제거 #306

Merged
merged 2 commits into from
Nov 29, 2023
Merged

refactor: jackson 의존성 제거 #306

merged 2 commits into from
Nov 29, 2023

Conversation

Juhongseok
Copy link
Member

🖥️ 이런 PR 입니다

jackson 의존성 제거

CC. 리뷰어

기존에 component 생성 DTO들이 jackson 의존성이 있어 해당 부분 새로운 통합 dto만들고 제거했습니다
동적으로 값을 주입하기 때문에 request body 자체는 변경되지 않습니다

테스트 설명

기타

Prefix

PR 코멘트를 작성할 때 항상 Prefix를 붙여주세요.

  • K1: 꼭 반영해주세요 (Request changes)
  • K2: 웬만하면 반영해 주세요 (Comment)
  • K3: 그냥 사소한 의견입니다 (Approve)

Copy link
Contributor

@ddongpuri ddongpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Contributor

@beomukim beomukim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Juhongseok Juhongseok merged commit 3acc33f into develop Nov 29, 2023
1 check passed
@Juhongseok Juhongseok deleted the refactor/GMMQ-742 branch November 29, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants