webui: Use client side decorations for browser #5057
Conversation
|
|
|
/packit test |
|
/packit build |
|
/kickstart-test --testtype smoke |
|
Does this fix or improve the title of the window in the overview, if you open it? How about the icon? |
|
halfline I wonder why do you need to set MOZ_GTK_TITLEBAR_DECORATION=client as it should be the default? If Firefox is running with system titlebar enabled it means system environment auto-detection is broken or non-existent. Is that expected? I mean it's okay to set MOZ_GTK_TITLEBAR_DECORATION=client but Firefox usually gets all config from system so if there's anything special you want to achieve (enabled system titlebar, different title etc.) there may be easier methods available than modify whole system setup for it. |
I think it's because it's running as root segregated from the rest of the session. It may not be needed after #5058 but I haven't test that.
Actually if you have insight into less fragile ways to allow list external url handlers than editing the sqlite database (see #5059 (comment) ), I'd be grateful. |
I don't think root is related here. Firefox uses XDG_* env variables to get system setup. I think if you set 'XDG_CURRENT_DESKTOP=GNOME' you'll get the same Firefox look as in regular gnome session (CSD enabled, titlebar off). |
I'm sure this can be handled somehow. Will look at it. |
Well it's not related to the uid of the running process directly, but escalating to root cleaves the app from aspects of the session and the environment (including |
Yes, Firefox uses CSD on all systems where XDG_CURRENT_DESKTOP is set, which includes KDE,Gnome,Mate,XFCE,Unity and so on. Non-decorated windows are used on twm and similar ones where XDG_CURRENT_DESKTOP is missing. If XDG_CURRENT_DESKTOP is set it also removes system titlebar - not sure if you want it. |
|
alright, let's just let XDG_CURRENT_DESKTOP bubble through then. |
Okay. Feel free to ping me if you have any Firefox related issues. |
At the moment we show a titlebar with "Mozilla Firefox" in the title. It looks much better to use client side decorations where the titlebar is rendered different and without Firefox branding. This commit achieves that by: 1. Undoing the config override that forces the server side titlebar to be on 2. Making sure more of the environment is bubbled through anaconda to the webui launcher. In particular, we need XDG_CURRENT_DESKTOP, but this commit brings it all through, so firefox runs in an environment as close to getting run directly by the live user as possible. 3. Two exceptions are XAUTHORITY and XDG_RUNTIME_DIR which need to remain unset until we can run firefox as a normal user instead of root.
When the user clicks the close button, it currently displays:
----
🌐 127.0.0.1
This page is asking you to confirm that you want to
leave — information you’ve entered may not be saved.
[ Stay on Page ] [ Leave Page ]
----
That is obviously not a great user experience.
Anaconda already has a way to abort the install and reboot, so
the close button isn't really adding much.
This commit hides the close button.
|
okay i added an additional commit to hide the close button. |
|
@VladimirSlavik time to land this? |
|
let's close this, now that #5112 has landed this isn't offering much I guess |
At the moment we show a titlebar with "Mozilla Firefox" in the title.
It looks much better to use client side decorations where the titlebar is rendered different and without Firefox branding.
This commit achieves that by: