Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Use client side decorations for browser #5057

Closed
wants to merge 2 commits into from

Commits on Sep 5, 2023

  1. webui: Use client side decorations for browser

    At the moment we show a titlebar with "Mozilla Firefox" in the
    title.
    
    It looks much better to use client side decorations where the
    titlebar is rendered different and without Firefox branding.
    
    This commit achieves that by:
    
    1. Undoing the config override that forces the server side titlebar to be on
    2. Making sure more of the environment is bubbled through anaconda to
       the webui launcher. In particular, we need XDG_CURRENT_DESKTOP, but
       this commit brings it all through, so firefox runs in an environment
       as close to getting run directly by the live user as possible.
    3. Two exceptions are XAUTHORITY and XDG_RUNTIME_DIR which need to
       remain unset until we can run firefox as a normal user instead of root.
    halfline committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    cc33fe5 View commit details
    Browse the repository at this point in the history
  2. webui: Hide close button in browser

    When the user clicks the close button, it currently displays:
    
    ----
    🌐 127.0.0.1
    
    This page is asking you to confirm that you want to
    leave — information you’ve entered may not be saved.
    
                          [ Stay on Page ] [ Leave Page ]
    ----
    
    That is obviously not a great user experience.
    
    Anaconda already has a way to abort the install and reboot, so
    the close button isn't really adding much.
    
    This commit hides the close button.
    halfline committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1c7c5da View commit details
    Browse the repository at this point in the history