Add a simple NVMe module for NVMe Fabrics support #5328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
This doesn't include any tests, I am not sure what we be good approach to test this, because the NVMe module basically doesn't really do anything other than calling |
vojtechtrefny
added
the
port to RHEL9
vojtechtrefny
force-pushed
the
master_nvme-of-support
branch
from
9d3fa03
to
013dfff
Compare
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
KKoukiou
reviewed
Nov 20, 2023
There was a problem hiding this comment.
I guess we will need some unit tests on this. Shall we find someone to support you on this @vojtechtrefny ?
Update: I just saw your comment. @poncovka do you have some suggestion maybe?
3 tasks
tbzatek
reviewed
Nov 28, 2023
vojtechtrefny
force-pushed
the
master_nvme-of-support
branch
from
013dfff
to
c62fc2d
Compare
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
poncovka
reviewed
Nov 29, 2023
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
vojtechtrefny
force-pushed
the
master_nvme-of-support
branch
from
415f37d
to
95c79af
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
I've added a simple unit test based on the FCoE test case and rebased the PR to the latest master to fix conflicts with the nvdimm removal change. |
VladimirSlavik
approved these changes
Dec 1, 2023
vojtechtrefny
force-pushed
the
master_nvme-of-support
branch
from
95c79af
to
6ba47ce
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
For now we want to support only NVMe Fabrics devices that don't require manual configuration so we need to just make sure the config files in /etc/nvme are fully populated before the installer starts and after the installation copied to the installed system. This is covered by calling the 'startup' and 'write' functions of the Blivet's NVMe module.
vojtechtrefny
force-pushed
the
master_nvme-of-support
branch
from
6ba47ce
to
388d47c
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we want to support only NVMe Fabrics devices that don't require manual configuration so we need to just make sure the config files in /etc/nvme are fully populated before the installer starts and after the installation copied to the installed system. This is covered by calling the 'startup' and 'write' functions of the Blivet's NVMe module.