Add test for EFI log processing

[elkoniu]

'/usr/libexec/anaconda/log-capture' is an util to generate runtime logs. This commit adds test validating output of this util.

[M4rtinK]

Looks good to me - thanks! :)

Just added some suggestions for using fragments to provide generic/boilerplate bits in the kickstart via kickstart fragments. :)

[M4rtinK]

I think other than the %post script this kickstart tests does not really need anything special, right ? In that case I would suggest using of the "common boilerplate" kickstart fragments instead to inject the common things. For example this one:

https://github.com/rhinstaller/kickstart-tests/blob/master/fragments/shared/common/common_no_payload.ks

A similar (mainly needs to do stuff in %post) kickstart tests that uses this fragment:

kickstart-tests/ui_cmdline.ks.in

Line 6 in 2ca0796

%ksappend common/common_no_payload.ks

[elkoniu]

Updated according to suggestion.

[M4rtinK]

The validation boilerplate could be replaced by this fragment: https://github.com/rhinstaller/kickstart-tests/blob/master/fragments/shared/validation/success_if_result_empty_standalone.ks

[elkoniu]

Updated according to suggestion

[elkoniu]

@M4rtinK thanks for the review. I have updated the code following your guidelines. Also I have split test cases in half: check if the util exists, call the util and expect 0 return code. Do you thing this is good enough validation?

[KKoukiou]

/test-tmt

[KKoukiou]

/test-os-variants

[M4rtinK]

@M4rtinK thanks for the review. I have updated the code following your guidelines. Also I have split test cases in half: check if the util exists, call the util and expect 0 return code. Do you thing this is good enough validation?

Agreed with the split - like this we can easily see from the logs what exactly went wrong, nice! :)

As for validation - it creates a tarball, right ? I guess we could check the file exists and is of non-zero size ? But I leave it up to you, given we already check the return code. :)