Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for EFI log processing #1324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions efi-log-check.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
SYSROOT=/mnt/sysroot
RESULT_FILE=${SYSROOT}/root/RESULT

# Check if log util can be called
function check_log_util_exist() {
if [ ! -f /usr/libexec/anaconda/log-capture ]; then
echo "*** Failed check: log-capture util does not exist" >> ${RESULT_FILE}
fi
}

# Check if log utils runs without failure
function check_log_util_runs() {
local exit_code=0

/usr/libexec/anaconda/log-capture

if [[ $? -ne ${exit_code} ]]; then
echo "*** Failed check: log-capture util cant be called" >> ${RESULT_FILE}
fi
}

25 changes: 25 additions & 0 deletions efi-log.ks.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
#version=DEVEL
#test name: efi-log
%ksappend repos/default.ks

%ksappend common/common_no_payload.ks

%packages
@core
%end

%post --nochroot

@KSINCLUDE@ efi-log-check.sh

check_log_util_exist
check_log_util_runs

%end

%post
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated according to suggestion


# No error was written to /root/RESULT file, everything is OK
%ksappend validation/success_if_result_empty_standalone.ks

%end
24 changes: 24 additions & 0 deletions efi-log.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#
# Copyright (C) 2024 Red Hat, Inc.
#
# This copyrighted material is made available to anyone wishing to use,
# modify, copy, or redistribute it subject to the terms and conditions of
# the GNU General Public License v.2, or (at your option) any later version.
# This program is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY expressed or implied, including the implied warranties of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
# Public License for more details. You should have received a copy of the
# GNU General Public License along with this program; if not, write to the
# Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
# 02110-1301, USA. Any Red Hat trademarks that are incorporated in the
# source code or documentation are not subject to the GNU General Public
# License and may only be used or replicated with the express permission of
# Red Hat, Inc.
#
# Red Hat Author(s): Paweł Poławski <[email protected]>

# Ignore unused variable parsed out by tooling scripts as test tags metadata
# shellcheck disable=SC2034
TESTTYPE="efi log coverage"

. ${KSTESTDIR}/functions.sh