Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix models integrity by using the "id" instead of "name" when dealing with models #916

Closed
GhaziTriki opened this issue Sep 14, 2023 · 0 comments
Closed

Fix models integrity by using the "id" instead of "name" when dealing with models #916

GhaziTriki opened this issue Sep 14, 2023 · 0 comments
Assignees
@hanazarraa
Labels
component: labels Changes related to labeling or categorization of issues or pull requests. component: presets Changes related to predefined settings or configurations. component: roles Changes related to user roles and permissions. component: rooms Changes related to virtual meeting rooms or spaces. priority: blocker Indicates that the issue or pull request is blocking progress and requires immediate attention. scope: quality Changes aimed at improving code or product quality. scope: robustness Changes aimed at enhancing the robustness of the application. scope: security Changes related to security measures and enhancements. type: bug Indicates that the issue or pull request addresses a bug or error.
Milestone
v1.0.0-alpha-2

Comments

@GhaziTriki
Copy link
Member

GhaziTriki commented Sep 14, 2023 •
edited
Loading

Describe the bug
Labels, rooms and presets are bing loaded by their names instead of their id. The should be the only and unique identifier when loading and saving those three models.

To Reproduce
Steps to reproduce the behavior: search PHP function with "byName".

Expected behavior
When dealing with records we should use the "id" column as identifier.

Possible solution
Refactor the code to use "id" and not any other column.

Additional context
It creates additional bugs related to the session.

#915 (comment)

#915 (comment)
@GhaziTriki GhaziTriki added type: bug Indicates that the issue or pull request addresses a bug or error. component: labels Changes related to labeling or categorization of issues or pull requests. component: presets Changes related to predefined settings or configurations. component: rooms Changes related to virtual meeting rooms or spaces. priority: blocker Indicates that the issue or pull request is blocking progress and requires immediate attention. scope: quality Changes aimed at improving code or product quality. scope: robustness Changes aimed at enhancing the robustness of the application. scope: security Changes related to security measures and enhancements. labels Sep 14, 2023
@GhaziTriki GhaziTriki added this to the v1.0.0-alpha-2 milestone Sep 14, 2023
@GhaziTriki GhaziTriki mentioned this issue Sep 14, 2023
Open
8 tasks
@GhaziTriki GhaziTriki added the component: roles Changes related to user roles and permissions. label Sep 15, 2023
@hanazarraa hanazarraa mentioned this issue Sep 15, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanazarraa hanazarraa

Labels
component: labels Changes related to labeling or categorization of issues or pull requests. component: presets Changes related to predefined settings or configurations. component: roles Changes related to user roles and permissions. component: rooms Changes related to virtual meeting rooms or spaces. priority: blocker Indicates that the issue or pull request is blocking progress and requires immediate attention. scope: quality Changes aimed at improving code or product quality. scope: robustness Changes aimed at enhancing the robustness of the application. scope: security Changes related to security measures and enhancements. type: bug Indicates that the issue or pull request addresses a bug or error.
Projects
None yet
Milestone
v1.0.0-alpha-2
Development

No branches or pull requests
2 participants
@GhaziTriki @hanazarraa