-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve session init and timeout handling #915
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some rooms for improvement to avoid the duplication of before route that can be implemented in the parent Base action.
Still the same problem as described above #915 (comment) |
there isnt anymore this function-> collectCurrentUser |
…tter routing naming for session init.
@@ -99,7 +100,18 @@ public function set($key, $value): void | |||
$this->f3->set('SESSION.' . $key, $value); | |||
$this->f3->sync('SESSION'); | |||
} | |||
public function getSession($sessionId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still problematic in production mode since session data is stored in redis in production environment.
# Conflicts: # bbbeasy-backend/app/config/access.ini
@marwa-benhassine Merges from PR #918 should fix edit issues. We can confirm with additional testing. |
Okay Sir @GhaziTriki |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description
Enter a brief description of the bug being fixed.
Changes Made
Describe the changes made to fix the bug
Closes Issue(s)
Related Issue(s)
Types of changes
Screenshots and screen captures