Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format code && Fix models integrity by using the "id" instead of "nam… #918

Merged
merged 1 commit into from
Sep 18, 2023
Merged

format code && Fix models integrity by using the "id" instead of "nam… #918

merged 1 commit into from
Sep 18, 2023

Conversation

hanazarraa
Copy link
Contributor

@hanazarraa hanazarraa commented Sep 15, 2023 •
edited by GhaziTriki
Loading

…e" when dealing with models

Description

Enter a brief description of the bug being fixed.

Changes Made

Fix models integrity by using the "id" instead of "name"
Describe the changes made to fix the bug

Closes Issue(s)

Related Issue(s)

#916

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Automated testing implementation or update
  • Dependencies updated to a newer version
  • Documentation update
  • Experimental feature that requires further discussion

Screenshots and screen captures

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@marwa-benhassine marwa-benhassine added the quality control: approved Changes Requested (for feedback from the QA testing team) label Sep 15, 2023
GhaziTriki
GhaziTriki approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@GhaziTriki GhaziTriki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things could be written better in the Model classes, but that's fine for now.

@GhaziTriki GhaziTriki added this to the v1.0.0-alpha-2 milestone Sep 18, 2023
@GhaziTriki GhaziTriki merged commit 843140f into riadvice:develop Sep 18, 2023
@GhaziTriki GhaziTriki mentioned this pull request Sep 18, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhaziTriki GhaziTriki GhaziTriki approved these changes

Assignees
No one assigned
Labels
quality control: approved Changes Requested (for feedback from the QA testing team)
Projects
None yet
Milestone
v1.0.0-alpha-2
Development

Successfully merging this pull request may close these issues.
3 participants
@hanazarraa @GhaziTriki @marwa-benhassine