Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Prepare for testing multiple ISAs #541

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jordancarlin
Copy link
Contributor

@UmerShahidengr New approach for testing multiple ISAs in CI. Instead of hardcoding the ISA strings, the matrix is built dynamically using any .yaml files in the .github/isa_templates directory. This allows for any of the configuration parameters to be modified and makes it easy to add new configurations to CI: just add a new configuration file to this directory.

For now I moved all of the templates that were in this directory into an old sub-directory (several of them are failing at the moment) and copied the two standard templates we had been using for CI into the directory.

@jordancarlin jordancarlin force-pushed the prepare_ci_for_multiple_extensions branch 2 times, most recently from 5e65115 to ffc3377 Compare November 7, 2024 07:51
@jordancarlin jordancarlin force-pushed the prepare_ci_for_multiple_extensions branch from ffc3377 to fb669c0 Compare December 2, 2024 06:53
@jordancarlin jordancarlin changed the title Prepare for testing multiple ISAs [CI] Prepare for testing multiple ISAs Dec 2, 2024
@jordancarlin jordancarlin force-pushed the prepare_ci_for_multiple_extensions branch from fb669c0 to 952d21e Compare January 6, 2025 05:18
@jordancarlin
Copy link
Contributor Author

@UmerShahidengr As more and more extensions are being added, this is something that we might want to revisit so that all of the tests can be run in CI. Right now, only a small subset are run, and it would take too long to run all of them (and some are incompatible, like F and Zfinx). This would allow multiple jobs to be started with different configurations so that various groups of tests can be run in parallel.

@UmerShahidengr
Copy link
Collaborator

I fully agree to your points @jordancarlin and it is in my to-do list. I still dont know what can be the best way to optimise the CI, and run all tests on all possible configurations in minimum possible time.
May be we can discuss this one in the upcoming SIG-ARCH meeting.
CC @allenjbaum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants