Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted cleanup #70

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Assorted cleanup #70

merged 2 commits into from
Sep 7, 2023

Conversation

andreiw
Copy link
Collaborator

@andreiw andreiw commented Aug 29, 2023

No description provided.

Andrei Warkentin added 2 commits August 25, 2023 22:20
Signed-off-by: Andrei Warkentin <[email protected]>
…d some uefi guiance

Signed-off-by: Andrei Warkentin <[email protected]>
@andreiw andreiw requested a review from adurbin-rivos August 31, 2023 03:11
@andreiw andreiw self-assigned this Aug 31, 2023
* [[acpi-hw-reduced]]Implement the HW-Reduced ACPI Mode.
** No FACS table.
** <<acpi-guidance-hw-reduced, See additional guidance>>.
* Implement a firmware-first ACPI Platform Error Interface (APEI) model (cite:[ACPI] Section 18.4).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this imply this is the only model? Or that something is exposed as opt-in for firmware first.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to the APEI portion? I just moved the text, but we can take the APEI requirements out for now if we need to dig into the details here (e.g. my personal opinion is that for BRS-I we mandate APEI, but there may be more work on the APEI side - but that's not really a BRS task by itself)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I was. I know you were moving things, but I did want to ask this question about the implications. I was mainly talking about 'firrmware-first APEI' as the only option. If that's the case, that's a discussion to be had. I can put it on the agenda for the next meeting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's put that on the agenda. I raised #71 so we don't lose track of it. I'll merge this pull request meanwhile.

@andreiw andreiw merged commit d191716 into riscv-non-isa:main Sep 7, 2023
@andreiw andreiw deleted the assorted-cleanup branch April 11, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants