Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the logical counter index in the snapshot area. #134

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

atishp04
Copy link
Collaborator

@atishp04 atishp04 commented Dec 3, 2023

The counter start/stop function clearly states that snapshot shared memory area is only valid for the counters being stopped/started in the respective calls. That means the logical counter index modified must be relative to the counter base provided in the start/stop call. Add more clarification to avoid any ambiguity.

The counter start/stop function clearly states that snapshot shared memory
area is only valid for the counters being stopped/started in the respective
calls. That means the logical counter index modified must be relative to the
counter base provided in the start/stop call. Add more clarification to avoid
any ambiguity.

Signed-off-by: Atish Patra <[email protected]>
@atishp04 atishp04 merged commit 3a05e2c into riscv-non-isa:master Dec 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant