-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructured codebase #316
Conversation
Signed-off-by: Myrausman <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 95.87% 96.53% +0.65%
==========================================
Files 10 10
Lines 752 750 -2
==========================================
+ Hits 721 724 +3
+ Misses 31 26 -5 ☔ View full report in Codecov by Sentry. |
@@ -457,7 +457,7 @@ def process_pseudo_instructions( | |||
logging.debug(f"Processing pseudo line: {line}") | |||
ext, orig_inst, pseudo_inst, line_content = pseudo_regex.findall(line)[0] | |||
ext_file = find_extension_file(ext, opcodes_dir) | |||
|
|||
# print("ext_file",ext_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete
@@ -514,6 +514,7 @@ def find_extension_file(ext: str, opcodes_dir: str): | |||
ext_file = f"{opcodes_dir}/unratified/{ext}" | |||
if not os.path.exists(ext_file): | |||
log_and_exit(f"Extension {ext} not found.") | |||
# print(ext_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete
@aswaterman as I know that I suggested for how to use
But I think, the earlier is quite good in displaying as we are already stating on LHS as
But again, whichever way you like, I think would be an appropriate one. |
I'll let you choose :) Let me know when it's ready to merge. |
Signed-off-by: Jay Dev Jha <[email protected]>
@aswaterman I have kept the earlier things itself as it is with no change in that as before, considering cleaner I think it could be merged now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM.
Restructured the codebase by moving all opcode extension files into a single 'extensions' folder, and updated paths in the code to reflect this new structure.