Install Sail from binary in CI #532
Conversation
Timmmm
force-pushed
the
user/timh/binary_release
branch
from
8d4298d
to
52c5bd2
Compare
.github/workflows/compile.yml
Outdated
| @@ -7,19 +7,17 @@ jobs: | |||
| runs-on: ubuntu-22.04 | |||
| steps: | |||
| - name: Install packages | |||
| run: sudo apt install -y opam zlib1g-dev pkg-config libgmp-dev z3 device-tree-compiler | |||
| run: sudo apt install -y opam zlib1g-dev pkg-config libgmp-dev device-tree-compiler curl | |||
There was a problem hiding this comment.
I think we should be able to get rid of opam now as well.
There was a problem hiding this comment.
I think it's still needed to build the OCaml version of the emulator which hasn't been removed yet. Actually I may need to keep the opam init, but I'll see what happens.
There was a problem hiding this comment.
We might be able to just install OCaml directly in that case and avoid opam init.
Timmmm
force-pushed
the
user/timh/binary_release
branch
3 times, most recently
from
5732cb9
to
c941569
Compare
|
A trick I use in the Sail CI to speed it up is to cache the |
Timmmm
force-pushed
the
user/timh/binary_release
branch
from
c941569
to
3340230
Compare
This should be a lot faster. It also means the version is pinned properly which wasn't the case before. I also recommended users to do the same in the README do they don't have to deal with OPAM.
Timmmm
force-pushed
the
user/timh/binary_release
branch
from
3340230
to
3535688
Compare
|
I'm hoping we can get away without OPAM as @jordancarlin suggested. If this attempt doesn't work I'm writing a Dockerfile so I can try it locally! The edit-build-test cycle for Github CI is ridiculous. |
|
Well, the C side seemed to work, but the OCaml build fails because it can't find Maybe I'll just finish #509 first. |
Test Results712 tests ±0 396 ✅ - 316 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 3535688. ± Comparison against base commit 05b845c. |
That probably makes sense because otherwise it’s just unnecessary work that’ll be quickly obsolete. Or we just leave opam for now (assuming it has all the needed dependencies). |
This should be a lot faster. It also means the version is pinned properly which wasn't the case before.
I also recommended users to do the same in the README do they don't have to deal with OPAM.