Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependabot): try to ignore some directories #16116

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Apr 3, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

dependabot/dependabot-core#4364 (comment)
#16101 (comment)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao
Copy link
Member

Why "try try"? 😄

- dependency-name: "*"
- package-ecosystem: cargo
directory: /integration_tests/feature-store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work for subdirectories? /integration_tests can meh?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk

Copy link
Contributor

@xiangjinwu xiangjinwu Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we get the answer: no

https://github.com/risingwavelabs/risingwave/network/updates/809611443

And it seems src/workspace-hack/Cargo.toml is still tracked by the main job.

@xxchan xxchan added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit d5bd3b0 Apr 3, 2024
9 of 10 checks passed
@xxchan xxchan deleted the xxchan/residential-guan branch April 3, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants