Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependabot): try to ignore some directories #16116

Merged
merged 1 commit into from
Apr 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,17 @@ updates:
- "mysql_async"
google-cloud:
patterns:
- "google-cloud*"
- "google-cloud*"
# Don't update these directories
- package-ecosystem: cargo
directory: /src/workspace-hack
schedule:
interval: "daily"
ignore:
- dependency-name: "*"
- package-ecosystem: cargo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work for subdirectories? /integration_tests can meh?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk

Copy link
Contributor

@xiangjinwu xiangjinwu Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we get the answer: no

https://github.com/risingwavelabs/risingwave/network/updates/809611443

And it seems src/workspace-hack/Cargo.toml is still tracked by the main job.

directory: /integration_tests/feature-store
schedule:
interval: "daily"
ignore:
- dependency-name: "*"
Loading