-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(meta): rename changelog shall check self.from
#19030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2024
hzxa21
approved these changes
Oct 21, 2024
yezizp2012
approved these changes
Oct 21, 2024
xxhZs
approved these changes
Oct 21, 2024
Minor test expectation conflict with #19029. Need to wait for it and rebase. |
xxhZs
added
need-cherry-pick-release-2.0
need-cherry-pick-release-1.10
Open a cherry-pick PR to branch release-1.10 after the current PR is merged
labels
Oct 24, 2024
xxhZs
pushed a commit
that referenced
this pull request
Oct 24, 2024
9 tasks
xxhZs
pushed a commit
that referenced
this pull request
Oct 24, 2024
9 tasks
xxhZs
pushed a commit
that referenced
this pull request
Oct 24, 2024
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…-2.1 (#19098) Signed-off-by: yihong0618 <[email protected]> Co-authored-by: yihong <[email protected]> Co-authored-by: xiangjinwu <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…-2.0 (#19096) Signed-off-by: yihong0618 <[email protected]> Co-authored-by: yihong <[email protected]> Co-authored-by: xiangjinwu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/run-e2e-single-node-tests
need-cherry-pick-release-1.10
Open a cherry-pick PR to branch release-1.10 after the current PR is merged
need-cherry-pick-release-2.0
need-cherry-pick-release-2.1
type/fix
Bug fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Minor bug since #17132 (v2.0.1)
Refer to the added test. It was blindly changing both
a
andb
intoc
in the definition ofmv
😓https://buildkite.com/risingwavelabs/pull-request/builds/60608#0192ada6-0ec6-4f20-9272-a53476d3d34c
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.