Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename dummy table id to tmp table id #19509

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Nov 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

I mistakenly thought "dummy" means placeholder. But it actually means a temporary id which will be replaced later. So I think "tmp" is a more proper name.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Nov 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@xxchan xxchan mentioned this pull request Nov 21, 2024
9 tasks
@xxchan xxchan marked this pull request as ready for review November 21, 2024 07:16
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍚

@xxchan xxchan added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 075c90d Nov 21, 2024
35 of 36 checks passed
@xxchan xxchan deleted the 11-21-refactor_rename_dummy_table_id_to_tmp_table_id branch November 21, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants