refactor: clarify the meaning of table in TableCatalog and TableFragments #19510
+231
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
yezizp2012
approved these changes
Nov 21, 2024
Base automatically changed from
11-21-refactor_rename_dummy_table_id_to_tmp_table_id
to
main
November 21, 2024 09:02
BugenZhao
reviewed
Nov 21, 2024
src/meta/src/rpc/ddl_controller.rs
Outdated
| @@ -1827,8 +1821,8 @@ impl DdlController { | |||
| // 3. Build the table fragments structure that will be persisted in the stream manager, and | |||
| // the context that contains all information needed for building the actors on the compute | |||
| // nodes. | |||
| let table_fragments = TableFragments::new( | |||
| (dummy_table_id as u32).into(), | |||
| let table_fragments = StreamJobFragments::new( | |||
There was a problem hiding this comment.
Class names are renamed while variables (or fields) still remain untouched. 😕
There was a problem hiding this comment.
I think renaming type is more important than renaming variables. It's so hard to change all occurances. 🥺
…ents Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
11-21-refactor_clarify_the_meaning_of_table_in_tablecatalog_and_tablefragments
branch
from
c78ebdd
to
b1c0736
Compare
Signed-off-by: xxchan <[email protected]>
st1page
approved these changes
Nov 22, 2024
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
xxchan
deleted the
11-21-refactor_clarify_the_meaning_of_table_in_tablecatalog_and_tablefragments
branch
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
What does "table" mean is quite confusing
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.