refactor(hub): hide rivetkit related tabs from ui

[jog1t]

Changes

Closes FRONT-694

Summary by CodeRabbit

• Refactor
  • Several actor-related features have been temporarily disabled in various components, resulting in a more streamlined interface for actor details and notifications.
  • Adjusted layout of hostnames in the actor network view to improve text truncation and display consistency.

[coderabbitai]

Walkthrough

The changes comment out the State, Connections, and Metrics features from various actor-related feature arrays and UI components, effectively hiding these tabs or options in the actor interface. Additionally, a minor UI adjustment wraps hostnames in a <span> with truncation styles in the actor network component.

Changes

File(s)	Change Summary
.../environments/$environmentNameId._v2/actors.tsx	Commented out State, Metrics, and Connections features in arrays passed to actor-related components.
.../components/src/actors/actor-context.tsx	Commented out Metrics, InspectReconnectNotification, Connections, State, and Console in feature arrays; adjusted fallback logic to selectively include Metrics.
.../components/src/actors/actor-network.tsx	Wrapped port.hostname in a <span> with truncation/flex CSS classes for improved UI rendering.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant ActorFeatureLogic

    User->>UI: Navigate to Actor page
    UI->>ActorFeatureLogic: Request available features for actor
    ActorFeatureLogic-->>UI: Return features (State, Connections, Metrics hidden)
    UI-->>User: Render actor UI without State, Connections, Metrics tabs

Loading

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Hide state, connections, and metrics tabs on actors (FRONT-694)	✅

Assessment against linked issues: Out-of-scope changes

Code Change (file_path)	Explanation
Wrap port.hostname in a <span> with truncation classes (frontend/packages/components/src/actors/actor-network.tsx)	This UI adjustment is not directly related to hiding state, connections, or metrics tabs as described in the linked issue.

Poem

A rabbit hops with nimble feet,
Hiding tabs that can't compete—
No state, no metrics, conns are gone,
The actor's stage moves swiftly on.
With hostnames trimmed and features neat,
The code now feels a lighter beat!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jog1t]

• fix(hub): hide internal actors #2725
• refactor(hub): hide rivetkit related tabs from ui #2724 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Claude finished @jog1t's task —— View job

---

PR Review: Hide RivetKit Related Tabs from UI

Review Tasks:

• Read and analyze changed files
• Examine code quality and best practices
• Check for potential bugs or issues
• Assess performance considerations
• Review security concerns
• Evaluate test coverage needs
• Provide comprehensive feedback

Summary

This PR refactors the actor UI by commenting out several RivetKit-related features to hide them from the interface. The changes primarily affect the tabs/features available in the actor detail views.

Code Review

✅ Positive Aspects

1. Minimal Impact: The changes are conservative, using comments rather than deletion, making future reversal easy
2. Consistent Pattern: The same features are consistently commented out across all relevant locations
3. Clear Intent: The refactoring clearly aligns with the PR title's goal

⚠️ Areas for Improvement

1. Code Hygiene: Using comments to disable features is not ideal for production code

   • Recommendation: Consider using feature flags or conditional rendering instead
   • Example: {showMetrics && ActorFeature.Metrics}

2. Documentation: No inline comments explaining why these features are disabled

   • Recommendation: Add brief comments explaining the business decision

3. Magic Numbers: The FIXED_TAGS constant on line 62-64 in actors.tsx hard-codes framework: "rivetkit" but the relationship to the hidden features isn't clear

🔧 Technical Issues

1. Potential Runtime Issues:

   • The code still references these features in type definitions and imports
   • Consider if any runtime checks depend on these features being available

2. Inconsistent Commenting:

   • Some locations use // comments while maintaining array structure
   • Consider consistent approach across all files

📊 Specific File Analysis

actors.tsx (lines 40-42, 103-104):

• Correctly maintains array structure while commenting features
• Good: No syntax errors introduced

actor-context.tsx (lines 391-392, 412-415):

• Features consistently commented in commonActorFeatures and conditional logic
• Good: Maintains logical flow

actor-network.tsx:

• No changes detected, which is appropriate for this refactor

🛡️ Security Concerns

• None identified - This is a UI refactoring that doesn't introduce security risks
• The changes only affect feature visibility, not data access or processing

🚀 Performance Considerations

• Minimal impact - Commenting out features may slightly improve performance by reducing rendered components
• No performance regressions expected

🧪 Test Coverage

• Recommendation: Ensure tests are updated to reflect the new expected behavior
• Tests should verify that these features are no longer accessible in the UI
• Consider adding tests for the feature toggle pattern if implemented

🎯 Suggestions for Future Improvement

1. Feature Flag Implementation:

   const features = [
     ActorFeature.Config,
     ActorFeature.Logs,
     ...(showAdvancedFeatures ? [
       ActorFeature.State,
       ActorFeature.Metrics,
       ActorFeature.Connections,
     ] : [])
   ];

2. Configuration-Based Approach:

   const RIVETKIT_FEATURES = {
     showMetrics: false,
     showConnections: false,
     showState: false,
   };

Overall Assessment

This is a straightforward refactoring that successfully achieves its goal of hiding RivetKit-related tabs. The code changes are minimal and low-risk, though the approach could be improved for maintainability.

Recommendation: ✅ Approve with suggestions - The changes are safe to merge, but consider implementing feature flags for better long-term maintainability.

---

[linear]

FRONT-694 Hide state & conns & metrics tabs on actors

[cloudflare-workers-and-pages]

Deploying rivet with    Cloudflare Pages

Latest commit:	8301911
Status:	✅  Deploy successful!
Preview URL:	https://f68eb327.rivet.pages.dev
Branch Preview URL:	https://07-07-refactor-hub-hide-rive.rivet.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying rivet-studio with    Cloudflare Pages

Latest commit:	8301911
Status:	🚫  Build failed.

View logs

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a28ea0 and 8301911.

📒 Files selected for processing (3)

• frontend/apps/hub/src/routes/_authenticated/_layout/projects/$projectNameId/environments/$environmentNameId._v2/actors.tsx (2 hunks)
• frontend/packages/components/src/actors/actor-context.tsx (2 hunks)
• frontend/packages/components/src/actors/actor-network.tsx (1 hunks)

🔇 Additional comments (4)

frontend/packages/components/src/actors/actor-network.tsx (1)

87-89: LGTM - Good UI improvement for long hostnames

The span wrapper with truncation classes is consistent with the existing pattern used for URLs and effectively handles hostname overflow in the UI.

frontend/apps/hub/src/routes/_authenticated/_layout/projects/$projectNameId/environments/$environmentNameId._v2/actors.tsx (1)

40-42: Verify feature consistency between ActorNotFound and ActorsActorEmptyDetails

The ActorNotFound component has ActorFeature.Metrics commented out, but the ActorsActorEmptyDetails component (lines 103-104) does not. This creates an inconsistency where metrics might be available in one context but not the other.

Confirm whether this difference in feature availability is intentional or if both components should have consistent feature sets.

frontend/packages/components/src/actors/actor-context.tsx (2)

418-418: Clarify the fallback feature configuration

The fallback case adds ActorFeature.Metrics explicitly, which contradicts its removal from commonActorFeatures. This creates inconsistent behavior where actors without the framework tag have more features than those with it.

Confirm whether this is the intended behavior or if the fallback should use commonActorFeatures without the additional Metrics feature.

---

412-415: No unintended functionality disabled
Verified that commenting out these ActorFeature flags only prevents the corresponding tabs/UI in actors-actor-details.tsx (and related components) from rendering for non-manager framework actors, which aligns with the PR’s goal of hiding rivetkit-related tabs. Core logic remains unchanged.

Affected flags and their usages:

• ActorFeature.Connections → Controls “Connections” tab
• ActorFeature.State → Controls “State” tab
• ActorFeature.Console → Controls “Console” tab
• ActorFeature.InspectReconnectNotification → Controls reconnect-notification behavior

No further changes required.

[coderabbitai]

⚠️ Potential issue

Inconsistent Metrics feature availability

There's a logical inconsistency in the feature configuration:

• commonActorFeatures excludes ActorFeature.Metrics (commented out here)
• The fallback return at line 418 explicitly includes ActorFeature.Metrics

This means actors without the framework tag will have Metrics available, while those with the framework tag will not. This seems counterintuitive.

🤖 Prompt for AI Agents

In frontend/packages/components/src/actors/actor-context.tsx around lines 391 to
392, the ActorFeature.Metrics is commented out in commonActorFeatures but
included in the fallback return at line 418, causing inconsistent availability
of the Metrics feature. To fix this, ensure ActorFeature.Metrics is either
consistently included or excluded in both places depending on the intended
behavior, so that actors with and without the framework tag have a consistent
feature set regarding Metrics.

[cloudflare-workers-and-pages]

Deploying rivet-hub with    Cloudflare Pages

Latest commit:	8301911
Status:	✅  Deploy successful!
Preview URL:	https://6c4a34be.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://07-07-refactor-hub-hide-rive.rivet-hub-7jb.pages.dev

View logs

[graphite-app]

Graphite Automations

"Test" took an action on this PR • (07/07/25)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.