Skip to content

refactor(hub): hide rivetkit related tabs from ui #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(hub): hide rivetkit related tabs from ui #2724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...henticated/_layout/projects/$projectNameId/environments/$environmentNameId._v2/actors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ function Actor() {
features={[
ActorFeature.Config,
ActorFeature.Logs,
ActorFeature.State,
ActorFeature.Metrics,
ActorFeature.Connections,
// ActorFeature.State,
// ActorFeature.Metrics,
// ActorFeature.Connections,
]}
/>
);
Expand Down Expand Up @@ -100,8 +100,8 @@ function Content() {
features={[
ActorFeature.Config,
ActorFeature.Logs,
ActorFeature.State,
ActorFeature.Connections,
// ActorFeature.State,
// ActorFeature.Connections,
]}
/>
)}
Expand Down
14 changes: 7 additions & 7 deletions frontend/packages/components/src/actors/actor-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,8 @@ const commonActorFeatures = [
ActorFeature.Logs,
ActorFeature.Config,
ActorFeature.Runtime,
ActorFeature.Metrics,
ActorFeature.InspectReconnectNotification,
// ActorFeature.Metrics,
// ActorFeature.InspectReconnectNotification,
Comment on lines +391 to +392
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Inconsistent Metrics feature availability

There's a logical inconsistency in the feature configuration:

  • commonActorFeatures excludes ActorFeature.Metrics (commented out here)
  • The fallback return at line 418 explicitly includes ActorFeature.Metrics

This means actors without the framework tag will have Metrics available, while those with the framework tag will not. This seems counterintuitive.

🤖 Prompt for AI Agents 
In frontend/packages/components/src/actors/actor-context.tsx around lines 391 to
392, the ActorFeature.Metrics is commented out in commonActorFeatures but
included in the fallback return at line 418, causing inconsistent availability
of the Metrics feature. To fix this, ensure ActorFeature.Metrics is either
consistently included or excluded in both places depending on the intended
behavior, so that actors with and without the framework tag have a consistent
feature set regarding Metrics.

];

export const currentActorFeaturesAtom = atom((get) => {
Expand All @@ -409,13 +409,13 @@ export const currentActorFeaturesAtom = atom((get) => {
}
return [
...commonActorFeatures,
ActorFeature.Connections,
ActorFeature.State,
ActorFeature.Console,
ActorFeature.InspectReconnectNotification,
// ActorFeature.Connections,
// ActorFeature.State,
// ActorFeature.Console,
// ActorFeature.InspectReconnectNotification,
];
}
return commonActorFeatures;
return [...commonActorFeatures, ActorFeature.Metrics];
}

return actor.features;
Expand Down
4 changes: 3 additions & 1 deletion frontend/packages/components/src/actors/actor-network.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ export function ActorNetwork({ actor }: ActorNetworkProps) {
className="max-w-full min-w-0"
value={port.hostname || ""}
>
{port.hostname}
<span className=" min-w-0 truncate flex-1">
{port.hostname}
</span>
</DiscreteCopyButton>
</Dd>
{port.url ? (
Expand Down
Loading