Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Achieved double stage friction wheel shooting #155

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Achieved double stage friction wheel shooting #155

merged 9 commits into from
Mar 4, 2024

Conversation

liyixin135
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Jan 16, 2024 •
edited
Loading

✅ Deploy Preview for rm-control-rm-controllers ready!

Name Link
🔨 Latest commit 67d55fe
🔍 Latest deploy log https://app.netlify.com/sites/rm-control-rm-controllers/deploys/65e441f1b04dbe0008dbd00d
😎 Deploy Preview https://deploy-preview-155--rm-control-rm-controllers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liyixin135
Copy link
Contributor Author

@1moule

@liyixin135
Copy link
Contributor Author

@ye-luo-xi-tui

@d0h0s
Copy link
Contributor

d0h0s commented Jan 17, 2024

我看好了，感觉没问题。

@1moule
Copy link
Contributor

1moule commented Jan 17, 2024

改完记得测一下，单级双极都要测

@liyixin135
Copy link
Contributor Author

改完记得测一下，单级双极都要测

现在pr的这个测过了，可以用，改完我再测一遍

1moule
1moule reviewed Jan 21, 2024
View reviewed changes
rm_shooter_controllers/src/standard.cpp Outdated
ctrl_friction_l->joint_.getVelocity() <= M_PI)
{
friction_left_rotate_state_ = false;
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break应该可以不写

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这咋不改，这个标志位其实可以跟下面用同一个，然后再改一下变量名吧 @liyixin135

@liyixin135
Copy link
Contributor Author

@1moule 单双级的仿真都跑过了

@1moule
Copy link
Contributor

1moule commented Jan 26, 2024

@1moule 单双级的仿真都跑过了

改完的点一下resolve，实车测一下

@liyixin135
Copy link
Contributor Author

@1moule 单双级的仿真都跑过了

改完的点一下resolve，实车测一下

用hero测了双级，standard5测了单级，都可以用

@liyixin135
Copy link
Contributor Author

@1moule 单双级的仿真都跑过了

改完的点一下resolve，实车测一下

用hero测了双级，standard5测了单级，都可以用

@1moule

@d0h0s d0h0s merged commit 18f9ed1 into rm-controls:master Mar 4, 2024
11 checks passed
@liyixin135 liyixin135 deleted the 4friction branch April 11, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1moule 1moule 1moule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liyixin135 @d0h0s @1moule