Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and updated: testCuiAbsolute app #206

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Conversation

rsantos88
Copy link
Contributor

Fixed and updated: testCuiAbsolute app

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 3d78122 on fix-testCuiAbsolute into 304b245 on develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 3d78122 on fix-testCuiAbsolute into 304b245 on develop.

@rsantos88 rsantos88 merged commit b1dc5a1 into develop Apr 5, 2019
@rsantos88 rsantos88 deleted the fix-testCuiAbsolute branch April 5, 2019 08:50
@PeterBowman
Copy link
Member

PeterBowman commented Apr 7, 2019

It turns out we merged a patch that does not compile on newer YARP releases (check Travis builds), let's avoid this in the future.

Edit: it's actually my fault, stuff like this shouldn't have gone into production.

https://github.com/roboticslab-uc3m/yarp-devices/pull/206/files#diff-5ead1331a2028af7ab27fc50eecf59fcR10

@PeterBowman
Copy link
Member

Fixed at a023145, this is being documented at roboticslab-uc3m/developer-manual#19 (FYI @rsantos88).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants