Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed topIsLow in yarp image #3145

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

randaz81
Copy link
Member

@randaz81 randaz81 commented Oct 16, 2024

The following methods:

bool topIsLowIndex() const
void setTopIsLowIndex(bool flag);

have been removed from yarp::sig::Image

bool topIsLowIndex() const
void setTopIsLowIndex(bool flag);

have been removed from yarp::sig::Image
@randaz81 randaz81 self-assigned this Oct 16, 2024
Copy link

update-docs bot commented Oct 16, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarcloud bot commented Oct 17, 2024

@randaz81
Copy link
Member Author

Ok for me, we need to fix yarp-matlab-bindings accordingly:

Thank you @Nicogene , I implemented your comment in the PR: robotology/yarp-matlab-bindings#106

@traversaro
Copy link
Member

I think we just need to regenerate the bindings once the PR is merged.

@randaz81 randaz81 merged commit 1e4c5ee into robotology:master Nov 12, 2024
47 of 50 checks passed
@randaz81 randaz81 deleted the image_no_topIsLow branch November 12, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants