Add more type hints #122
Open
Add more type hints #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
commented
Jan 16, 2022
| self._api = NtCoreApi(self.__createEntry) | ||
| self._tables = {} | ||
| self._entry_listeners = {} |
There was a problem hiding this comment.
Turns out this is completely unused.
virtuald
reviewed
Jan 17, 2022
| @@ -0,0 +1,11 @@ | |||
| from typing import Sequence, Union | |||
There was a problem hiding this comment.
Breaking what would otherwise be a cyclic import. I'd just put this at networktables/types.py, but… yeah.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an explicit value union type, ensuring the documented types are in the type hints.
Also fix a few mypy warnings.