Major refactor #209
Merged
Major refactor #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtuald
force-pushed
the
refactor
branch
9 times, most recently
from
67587ba
to
da8f81c
Compare
auscompgeek
reviewed
Sep 2, 2023
virtuald
force-pushed
the
refactor
branch
3 times, most recently
from
121cf75
to
966e4c6
Compare
- jinja templates now should generate only from dataclasses defined in j2_context.py - Make some logic clearer and more efficient
virtuald
force-pushed
the
refactor
branch
2 times, most recently
from
dcf121b
to
ab94658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards migrating to cxxheaderparser. The goal here is to make some of the logic clearer, and have the generative jinja files only generate using defined data classes in j2_context.py.
Tests pass locally for me, but not going to merge this until I build all robotpy projects locally and add some missing tests that I found along the way:
py::self - float())I think I want to do some more file renaming/clarifying also before we merge this.